incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhangjf <zhan...@apache.org>
Subject Re: svn commit: r1388877 - in /incubator/ooo/trunk/main: cui/source/dialogs/ cui/source/inc/ default_images/introabout/ default_images/res/ desktop/zipintro/ sd/source/ui/slideshow/ sfx2/inc/sfx2/ sfx2/source/appl/ vcl/inc/vcl/ vcl/source/gdi/
Date Tue, 25 Sep 2012 13:44:26 GMT
Hi,

Before I notice this discussion, I have already committed the fix code
for this problem by revision 1389717. I also don't have an idea why it
doesn't work. The fix code build passed on both Mac and Linux.  Let me
know if you have any concerns.

regards,
zhangjf

On Tue, Sep 25, 2012 at 7:12 PM, Andre Fischer <awf.aoo@gmail.com> wrote:
> On 24.09.2012 21:12, Pavel Janík wrote:
>>>
>>> * and the using declaration:
>>>
>>>   using namespace com::sun::star;
>>>
>>> The compiler should detect that system::XSystemShellExecute is
>>> com::sun::star::system::XSystemShellExecute and so on, unless it
>>> collides with a system namespace on the system's headers ?
>>>
>>> Anyway feel free to commit it, if this solves your problem.
>
>
> Your change looks fine.  Please commit it.
>
>
>> I'll wait for other's opinions, because I too thought that it should work
>> as written (using c:s:s), weird.
>>
>> Other parts of the code use
>>
>> namespace css = com::sun::star;
>> uno::Reference<  css::system::XSystemShellExecute>  xSystemShell(...
>>
>> despite the fact that using namespace com::sun::star is there as well.
>> Maybe "system" is somehow strange.
>>
>> Any ideas about the strangeness? ;-)
>
>
> Hm, the only thing I can think of is the Koenig lookup that may be
> implemented differently on your compilers.  But I assume that the two of you
> both tried this on Linux and thus probably on very similar compilers.
>
> -Andre
>
>

Mime
View raw message