incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lei Wang <lei.wang.l...@gmail.com>
Subject Re: svn commit: r1379349 - in /incubator/ooo/trunk/main: offapi/com/sun/star/sheet/ offapi/type_reference/ oox/inc/oox/xls/ oox/source/xls/ sc/inc/ sc/source/core/data/ sc/source/core/tool/ sc/source/filter/excel/ sc/source/filter/xml/ sc/source/ui/i
Date Mon, 03 Sep 2012 10:35:42 GMT
Hi Ariel

Thanks for your suggestion. I will work with Zhao Shao Zhi to add 2 new
interfaces instead of adding new member functions to the existed interface.

BTW,

Why there are duplicated codes in binfilter\inc\bf_sc and sc\inc?

On Mon, Sep 3, 2012 at 12:54 PM, Ariel Constenla-Haile
<arielch@apache.org>wrote:

> Hi
>
> On Fri, Aug 31, 2012 at 08:11:10AM -0000, leiw@apache.org wrote:
> > Author: leiw
> > Date: Fri Aug 31 08:11:09 2012
> > New Revision: 1379349
> >
> > URL: http://svn.apache.org/viewvc?rev=1379349&view=rev
> > Log:
> > #i120478 Enhancement request: support sheet scoped named ranges in Calc
> >
> >           Patch by: zhaoshzh (Zhao Shao Zhi)
> >           Review by: Wang Lei
>
> This commit breaks the build in binfilter, its changes weren't applied
> to that module. See
> http://svn.apache.org/viewvc?view=revision&revision=1379914 I added
> a dummy implementation only to make it build.
>
>
> >
> > Modified:
> >     incubator/ooo/trunk/main/offapi/com/sun/star/sheet/XNamedRange.idl
> >     incubator/ooo/trunk/main/offapi/com/sun/star/sheet/XNamedRanges.idl
> >     incubator/ooo/trunk/main/offapi/type_reference/types.rdb
>
> trunk is still in 3.*, IMO published API cannot be changed in an
> incompatible way until 4. You should add for now a XNamedRange2 and
> a XNamedRanges2. See attached patch.
>
> On the other hand, it would be nice to first discuss here API changes
> o new API design, with a proper thread taged [API].
>
>
> > Modified:
> incubator/ooo/trunk/main/offapi/com/sun/star/sheet/XNamedRanges.idl
> > URL:
> http://svn.apache.org/viewvc/incubator/ooo/trunk/main/offapi/com/sun/star/sheet/XNamedRanges.idl?rev=1379349&r1=1379348&r2=1379349&view=diff
> >
> ==============================================================================
> > --- incubator/ooo/trunk/main/offapi/com/sun/star/sheet/XNamedRanges.idl
> (original)
> > +++ incubator/ooo/trunk/main/offapi/com/sun/star/sheet/XNamedRanges.idl
> Fri Aug 31 08:11:09 2012
> > @@ -44,6 +44,26 @@
> >
> >  module com {  module sun {  module star {  module sheet {
> >
>
> a) this is not published API, so don't tag it like that
> b) it should be in its own idl file
>
>
> > +published struct RangeScopeName
> > +{
> > +
>  //-------------------------------------------------------------------------
> > +
> > +    /** is the OpCode of the token.
> > +
> > +        @see com::sun::star::sheet::XFormulaOpCodeMapper
> > +     */
> > +    string ScopeName;
> > +
> > +
> //-------------------------------------------------------------------------
> > +
> > +    /** is additional data in the token, depending on the OpCode.
> > +
> > +        @see com::sun::star::sheet::NamedRange::TokenIndex
> > +        @see com::sun::star::sheet::DatabaseRange::TokenIndex
> > +     */
> > +    string RangeName;
> > +};
>
> [...]
>
> > +     void addNewByScopeName(
> > +                     [in] string aScopeName,
> > +                     [in] string aRangeName,
> > +                     [in] string aContent,
> > +                     [in] com::sun::star::table::CellAddress aPosition,
> > +                     [in] long nType );
> > +
> > +     void removeByScopeName( [in] string aScopeName, [in] string
> aRangeName );
> > +
> > +     boolean hasByScopeName( [in] string aScopeName, [in] string
> aRangeName );
> > +
> > +     any getByScopeName( [in] string aScopeName, [in] string aRangeName
> )
> > +                     raises(
> com::sun::star::container::NoSuchElementException,
> > +
> com::sun::star::lang::WrappedTargetException );
>
>
> I don't get this, why two string parameters aScopeName and aRangeName,
> and not one RangeScopeName? I might be missing something.
>
>
> Regards
> --
> Ariel Constenla-Haile
> La Plata, Argentina
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message