incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pavel Janík <Pa...@Janik.cz>
Subject Re: WaE: sd/source/ui/slideshow/slideshowimpl.cxx
Date Wed, 26 Sep 2012 08:48:54 GMT

On Sep 26, 2012, at 10:45 AM, Andre wrote:

> On 09/25/2012 07:57 PM, Pavel Janík wrote:
>> Hi,
>> 
>> this code emits Warning about unused bLoad:
>> 
>> bool bLoad = vcl::ImageRepository::loadBrandingImage(
>>                   rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "logo" ) ),
>>                                  aImage );
>> OSL_ENSURE( bLoad, "Can't load logo image");
>> 
>> Can't we OSL_ENSURE that aImage is initialized properly instead?
> 
> Maybe we can do that additionally, loading is not the same as initialization.
> I would just add
> 
>    (void)bLoad;

That was my first guess, but the code looks strange this way ;-) But I'd let this decision
on the author of the code.
-- 
Pavel Janík




Mime
View raw message