incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Rist <andrew.r...@oracle.com>
Subject Re: [BUILD] atlthunk
Date Tue, 11 Sep 2012 17:46:33 GMT

On 9/11/2012 4:31 AM, Oliver-Rainer Wittmann wrote:
> Hi Herbert,
>
> On 11.09.2012 13:17, Herbert Duerr wrote:
>> Hi Andrew,
>>
>> On 10.09.2012 22:19, Andrew Rist wrote:
>>> do you know the context for this change?
>>> https://svn.apache.org/viewvc?view=revision&revision=1343720 - "force
>>> atlthunk addition when linking with atls library"
>>> The lack of atlthunk is stopping the build and the file doesn't seem to
>>> be in VS 2008 pro.  (Or is there something I did not install when
>>> installing VS 2008?)
>>
>> With the free MSVC2008 Express being the baseline for AOO development 
>> on Windows
>> the atlthunk addition was needed to enable the build of a fully 
>> functional
>> product, because MSVC2008 Express does not contain the ATL libraries, 
>> but the
>> free WDK contains all that is needed including the atlthunk lib.
>>
>> Requiring an expensive Pro version to build it would be prohibitive 
>> for hobby
>> developers.
>>
>> BTW: Chromium has the same issue and the instructions there apply 
>> here too.
>> If you use Visual Studio 2008 Express:
>>      Install the WDK for the ATL headers and libs from e.g.
>> http://www.microsoft.com/en-us/download/details.aspx?id=11800
>>      Verify MSVC|Tools|Options|Projects and Solutions|VC++ 
>> Directories has
>> Include: [WDK]include\atl71 and Lib: [WDK]lib\Atl\i386 where [WDK] is 
>> the WDK
>> install directory.
>>
>> Another solution would be to detect that atlthunk is not needed 
>> because the
>> --disable-atl configure switch is active or disable linking to the 
>> atlthunk if
>> an MSVC version containing atl directly is installed.
>>
>> Another alternative would be of course if we demanded that everyone 
>> wanting to
>> build a fully functional AOO is required to get the Pro version. Is that
>> something we could strive for?
>>
>
> I think you misunderstood my intention.
>
> I am aiming for something which enables building with VS 2008 Express 
> _and_ with VS 2008 Pro.
> And yes, VS 2008 Express should be the default assumed environment 
> from my point of view.
This was my intent also.  I am in favor of VS 2008 Express being the 
default environment.
The changes needed to do this should not break the build with VS 2008 
Pro, which is the case now.
In the make file, there seem to be branch in the makefile for 
'PROF_EDITION' - I guess this does not id Pro vs Express - if so we 
could just ifdef around the atlthunk.

    .IF "$(GUI)" == "WNT" && "$(DISABLE_ACTIVEX)"==""
       PROF_EDITION=TRUE
    .ENDIF


This came about when I attempted to update the Win buildbot to build the 
same builds as the 'unofficial builds'.
It would be good to have ATL, ActiveX and DirectX all activated.  I am 
not able to edit a file on the fly to get the build to work.
So I am trying to get a full Win build with 'stock' files.

A.


>
> As far as I know the above referenced code change is only one part of 
> enabling the build of VS 2008 Express with ATL enabled - see issue 118821
>
> [1] https://issues.apache.org/ooo/show_bug.cgi?id=118821
>
>
> Best regards, Oliver.


Mime
View raw message