# incubator-ooo-dev mailing list archives

##### Site index · List index
Message view
Top
From Jürgen Schmidt <jogischm...@gmail.com>
Subject Re: Duplicate code in module binfilter [was: Re: svn commit: r1379349 - in /incubator/ooo/trunk/main: offapi/com/sun/star/sheet/ offapi/type_reference/ oox/inc/oox/xls/ oox/source/xls/ sc/inc/ sc/source/core/data/ sc/source/core/tool/ sc/source/filte
Date Tue, 04 Sep 2012 07:49:02 GMT
On 9/4/12 3:42 AM, Lei Wang wrote:
> Hi,
>
> So we have plan to remove import/export code from application
> modules(sw,sc,sd...) and implement import/export function in binfilter. Is

no, the plan is more to drop the older binary formats and to drop the
ugly binfilter module. I think a good candidate for this drop is the
next major version.

This is of course a change where people will have different opinions on
it. But I personally see no real problem, the code becomes smaller, the
officer becomes smaller and the old formats can be migrated by an
existing version, for example AOO 3.4.

The default is ODF and most users don't use the older binary formats.
But again these formats can be migrated with existing and still
available older version of the office.

We should start a new thread to discuss this drop of binfilter for the
next major version.

Juergen

>
> On Mon, Sep 3, 2012 at 10:45 PM, Oliver-Rainer Wittmann <
>
>> Hi,
>>
>> On 03.09.2012 12:35, Lei Wang wrote:
>>
>>> [snip]
>>>
>>> Why there are duplicated codes in binfilter\inc\bf_sc and sc\inc?
>>>
>>>
>> The module binfilter is more or less a stripped version of the complete
>> code in order to get rid of the import/export code for our former used
>> native binary file format in the rest of the modules.
>> Thus, it is quite natural that we have code duplications in this module.
>>
>> Best regards, Oliver.
>>
>


Mime
View raw message