incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ariel Constenla-Haile <arie...@apache.org>
Subject Re: svn commit: r1388877 - in /incubator/ooo/trunk/main: cui/source/dialogs/ cui/source/inc/ default_images/introabout/ default_images/res/ desktop/zipintro/ sd/source/ui/slideshow/ sfx2/inc/sfx2/ sfx2/source/appl/ vcl/inc/vcl/ vcl/source/gdi/
Date Mon, 24 Sep 2012 18:51:17 GMT
Hi Pavel,

On Mon, Sep 24, 2012 at 08:31:35PM +0200, Pavel Janík wrote:
> 
> On Sep 24, 2012, at 8:28 PM, Pavel Janík wrote:
> 
> > Hi,
> > 
> > the following change made about.cxx uncompilable on my system:
> > 
> > Compiling: cui/source/dialogs/about.cxx
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx: In member
function ‘long int AboutDialog::OpenLinkHdl_Impl(svt::FixedHyperlink*)’:
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537: error:
‘system’ has not been declared
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537: error:
‘XSystemShellExecute’ was not declared in this scope
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537: error:
template argument 1 is invalid
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:537: error:
invalid type in declaration before ‘(’ token
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:541: error:
initializer expression list treated as compound expression
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:542: error:
request for member ‘is’ in ‘xSystemShell’, which is of non-class type ‘int’
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:543: error:
base operand of ‘->’ is not a pointer
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:543: error:
‘system’ has not been declared
> > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs/about.cxx:543: error:
‘DEFAULTS’ was not declared in this scope
> > dmake:  Error code 1, while making '../../unxmacxi.pro/slo/about.obj'
> > ERROR: error 65280 occurred while making /Users/pavel/BUILD/BuildDir/ooo_trunk_src/cui/source/dialogs
> 
> The following made it compile again:
> 
> Index: about.cxx
> ===================================================================
> --- about.cxx	(revision 1389508)
> +++ about.cxx	(working copy)
> @@ -534,13 +534,13 @@
>          {
>              uno::Reference< uno::XComponentContext > xContext =
>                  ::comphelper::getProcessComponentContext();
> -            uno::Reference< system::XSystemShellExecute > xSystemShell(
> +            uno::Reference< com::sun::star::system::XSystemShellExecute > xSystemShell(

it looks like this change shouldn't be needed at all:

* there are the include directives:

  #include <com/sun/star/system/SystemShellExecuteFlags.hpp>
  #include <com/sun/star/system/XSystemShellExecute.hpp>

* and the using declaration:

  using namespace com::sun::star;

The compiler should detect that system::XSystemShellExecute is
com::sun::star::system::XSystemShellExecute and so on, unless it
collides with a system namespace on the system's headers ? 

Anyway feel free to commit it, if this solves your problem.


Regards
-- 
Ariel Constenla-Haile
La Plata, Argentina

Mime
View raw message