Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ooo-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of lei.wang.leiw@gmail.com
 designates 209.85.212.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <501934E4.9080903@apache.org>
References: 
 <CACR2vQ46b0fmZwnMjqFzhMzxr6UQtsS_hrpRPeqPp0=H-Hf8ww@mail.gmail.com>
	<501934E4.9080903@apache.org>
Date: Thu, 2 Aug 2012 11:28:22 +0800
Message-ID: 
 <CA+mMfTd0f7nDo656KzffhmQVnWCPhYY4Y2WyjMYZOPo77SA2Fg@mail.gmail.com>
Subject: 
 =?UTF-8?Q?Re=3A_=5BCall=2Dfor=2D=E2=80=8B=E2=80=8BReview=5D=5BCalc=5DData_validity_works?=
	=?UTF-8?Q?_incorrectly_with_criteria_=22Allow_text_length=22_for_numbers?=
From: Lei Wang <lei.wang.leiw@gmail.com>
To: ooo-dev@incubator.apache.org
Content-Type: multipart/alternative; boundary=f46d0438936fe811ca04c640001d

--f46d0438936fe811ca04c640001d
Content-Type: text/plain; charset=ISO-8859-1

Herbert, thank you for applying the patch. I planed to do it. But after
merging this patch and updating to latest trunk code, I can not build trunk
successfully for several days.

On Wed, Aug 1, 2012 at 9:53 PM, Herbert Duerr <hdu@apache.org> wrote:

> On 25.07.2012 07:11, Zhang Lu wrote:
>
>> One fix for review.
>>
>> https://issues.apache.org/ooo/**show_bug.cgi?id=93128<https://issues.apache.org/ooo/show_bug.cgi?id=93128>
>> [...]
>>
>> Root cause: There is no flow to handle a real number when selecting string
>> length operation
>>
>> Solution: if operation is string length type, to get the number's length,
>> and consider it as a string.
>>
>
> Great! I reviewed, tested and applied your patch.
>
> Herbert
>

--f46d0438936fe811ca04c640001d--