incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pavel Janík <Pa...@Janik.cz>
Subject Re: svn commit: r1366403 - /incubator/ooo/trunk/main/svtools/source/filter/wmf/enhwmf.cxx
Date Fri, 10 Aug 2012 19:36:42 GMT
Hi,

On Jul 27, 2012, at 5:01 PM, alg@apache.org wrote:

> Author: alg
> Date: Fri Jul 27 15:01:18 2012
> New Revision: 1366403
> 
> URL: http://svn.apache.org/viewvc?rev=1366403&view=rev
> Log:
> #119450# Added EMR_ALPHABLEND case to EnhWMFReader to correct visualisations
> Patch by: Jianyuan Li
> Review by: alg
> 
> Modified:
>    incubator/ooo/trunk/main/svtools/source/filter/wmf/enhwmf.cxx
> 
> Modified: incubator/ooo/trunk/main/svtools/source/filter/wmf/enhwmf.cxx
> URL: http://svn.apache.org/viewvc/incubator/ooo/trunk/main/svtools/source/filter/wmf/enhwmf.cxx?rev=1366403&r1=1366402&r2=1366403&view=diff
> ==============================================================================
> --- incubator/ooo/trunk/main/svtools/source/filter/wmf/enhwmf.cxx (original)
> +++ incubator/ooo/trunk/main/svtools/source/filter/wmf/enhwmf.cxx Fri Jul 27 15:01:18
2012
> @@ -805,7 +820,63 @@ sal_Bool EnhWMFReader::ReadEnhWMF()
> 				pOut->SetClipPath( aPolyPoly, iMode, sal_False );
> 	        }
>             break;

> ...

> +						// test if it is sensible to crop
> +						if ( ( cxSrc > 0 ) && ( cySrc > 0 ) && 
> +							( xSrc >= 0 ) && ( ySrc >= 0 ) &&
> +								( xSrc + cxSrc <= aBitmap.GetSizePixel().Width() ) &&
> +									( ySrc + cySrc <= aBitmap.GetSizePixel().Height() ) )

These two last lines (869, 870) print this warning when compiling with WaE:

svtools/source/filter/wmf/enhwmf.cxx: In member function ‘sal_Bool EnhWMFReader::ReadEnhWMF()’:
svtools/source/filter/wmf/enhwmf.cxx:869: warning: comparison between signed and unsigned
integer expressions
svtools/source/filter/wmf/enhwmf.cxx:870: warning: comparison between signed and unsigned
integer expressions

-- 
Pavel Janík




Mime
View raw message