incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andre Fischer <awf....@gmail.com>
Subject Re: Need to Revisit RAT Excludes and Wildcards
Date Thu, 23 Aug 2012 06:37:46 GMT
On 23.08.2012 02:43, Rob Weir wrote:
> On Mon, Aug 20, 2012 at 6:05 PM, Dave Fisher <dave2wave@comcast.net> wrote:
>> Hi Folks,
>>
>> We are really getting ahead of ourselves.
>>
>> We have a legitimate -1 IPMC vote on our release, it might get changed - Marvin asked
for confirmation that the IPMC votes are based only on the official SOURCE release.
>>
>> I looked again at the rat-excludes and we should look into a small handful of binary
files that slip through. Most are "test" files and should be OK, but there are a small number
that are not. If we have a plan to remove them and/or show that they are unused and harmless
it may be that Marvin will be convinced to change his vote.
>>
>> Someone should inspect these wildcards in the source tree
>> **/*.dbf
>> **/*.dbt
>> **/*.jar
>> **/*.zip
>> **/*.class
>> **/*.dll
>> **/*.exe
>> **/*.mdb
>>
>
> A quick general observation:
>
> Wildcard exclusions are dangerous.  They may be useful but they are
> dangerous.  Does RAT have a mode where we can dump a list of all
> excluded files?  Not just the patterns, but the files?

While Rat has functionality for excluding files, we are using Ant to 
exclude the files.  main/rat-excludes is fed directly to Ant to do that.

I am currently integrating the rat scan into our build.  Adding a target 
to produce the negative list of files that are excluded should be simple.

>
> If so, that might be a good thing to enable, just so we're aware when
> reviewing the report, to make sure that more is not excluded than we
> intended.
>
> If this isn't an option in RAT, maybe this is a patch we can send them?

I have already contacted the Rat team (no pun intended) for another 
matter: marking binary files as binary, not for excluding them from the 
scan, but for excluding their content to be included in the report. 
With that we can identify binary files that where accidentally checked 
in much easier.  Excluding binary files from the scan with wildcards 
just to keep the report readable will then not be necessary anymore.

-Andre


>
> -Rob
>
>> E.G.
>>
>> $ find . -name "*.jar"
>> ./avmedia/source/java/avmedia.jar
>> ./qadevOOo/testdocs/qadevlibs/JobExecutor.jar
>> ./qadevOOo/testdocs/qadevlibs/MyPersistObjectImpl.jar
>> ./stax/download/README_stax-1.2.0.jar
>> ./testautomation/global/input/xslt_stylesheets/docbook.jar
>> ./testautomation/global/input/xslt_stylesheets/excel.jar
>> ./testautomation/global/input/xslt_stylesheets/word.jar
>> ./testautomation/global/input/xslt_stylesheets/xhtml.jar
>> ./testgraphical/ui/java/ConvwatchGUIProject/dist/ConvwatchGUIProject.jar
>> ./xmlsecurity/test_docs/tools/httpserv/dist/httpserv.jar
>>
>> $ ls -lart ./avmedia/source/java
>> total 208
>> -rw-r--r--@  1 dave  staff     48 Nov  1  2011 manifest
>> -rw-r--r--@  1 dave  staff  15776 Nov  1  2011 avmedia.jar
>> drwxr-xr-x@ 10 dave  staff    340 Nov  1  2011 ..
>> -rw-r--r--@  1 dave  staff   6553 Nov  7  2011 FrameGrabber.java
>> drwxr-xr-x@  3 dave  staff    102 Nov  7  2011 x11
>> -rw-r--r--@  1 dave  staff  21629 Nov  7  2011 WindowAdapter.java
>> -rw-r--r--@  1 dave  staff  20064 Nov  7  2011 PlayerWindow.java
>> -rw-r--r--@  1 dave  staff   2120 Nov  7  2011 MediaUno.java
>> drwxr-xr-x@  3 dave  staff    102 Nov  7  2011 win
>> -rw-r--r--@  1 dave  staff   9906 Nov  7  2011 Player.java
>> -rw-r--r--@  1 dave  staff   4367 Nov  7  2011 Manager.java
>> -rw-r--r--@  1 dave  staff   2132 Jan 19  2012 makefile.mk
>> -rw-r--r--@  1 dave  staff   1230 Jan 19  2012 avmedia.jar.component
>> drwxr-xr-x@ 14 dave  staff    476 Jan 19  2012 .
>>
>> $ jar tvf ./avmedia/source/java/avmedia.jar
>>     104 Thu Jun 10 20:27:16 PDT 2010 META-INF/MANIFEST.MF
>>    1277 Thu Jun 10 20:27:16 PDT 2010 MediaUno.class
>>    4872 Thu Jun 10 20:27:16 PDT 2010 Player.class
>>    8279 Thu Jun 10 20:27:16 PDT 2010 PlayerWindow.class
>>    7738 Thu Jun 10 20:27:16 PDT 2010 WindowAdapter.class
>>       0 Thu Jun 10 19:46:36 PDT 2010 avmedia/
>>       0 Thu Jun 10 20:27:16 PDT 2010 avmedia/META-INF/
>>     104 Thu Jun 10 20:27:16 PDT 2010 avmedia/META-INF/MANIFEST.MF
>>    1418 Thu Jun 10 20:27:16 PDT 2010 SystemWindowAdapter.class
>>    3883 Thu Jun 10 20:27:16 PDT 2010 FrameGrabber.class
>>    2066 Thu Jun 10 20:27:16 PDT 2010 Manager.class
>>
>> It looks like the jar file is unnecessary, but it may be in use.
>>
>> Regards,
>> Dave
>>
>> PS. Sure glad that we did as suggested by Pedro ;-)
>>


Mime
View raw message