incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pavel Janík <Pa...@Janik.cz>
Subject Re: svn commit: r1372411 - /incubator/ooo/trunk/main/sw/source/filter/ww8/ww8par5.cxx
Date Tue, 14 Aug 2012 13:47:46 GMT
Hi,

On Aug 13, 2012, at 3:04 PM, orw@apache.org wrote:

> Author: orw
> Date: Mon Aug 13 13:04:34 2012
> New Revision: 1372411
> 
> URL: http://svn.apache.org/viewvc?rev=1372411&view=rev
> Log:
> #119440# - method <SwWW8ImplReader::Read_SubF_Combined(..)>
>         -- add support for further field codes
> 
>         Found by: Yan Ji
>         Patch by: zjcen
>         Review by: orw
> 
> Modified:
>    incubator/ooo/trunk/main/sw/source/filter/ww8/ww8par5.cxx
> 
> Modified: incubator/ooo/trunk/main/sw/source/filter/ww8/ww8par5.cxx
> URL: http://svn.apache.org/viewvc/incubator/ooo/trunk/main/sw/source/filter/ww8/ww8par5.cxx?rev=1372411&r1=1372410&r2=1372411&view=diff
> ==============================================================================
> --- incubator/ooo/trunk/main/sw/source/filter/ww8/ww8par5.cxx (original)
> +++ incubator/ooo/trunk/main/sw/source/filter/ww8/ww8par5.cxx Mon Aug 13 13:04:34 2012

> +                            const sal_Unicode cC = sPart.GetChar(nBegin+1);
> +                            if ( (-1 < cC) && (cC < 32) )

This code results in this warning:

sw/source/filter/ww8/ww8par5.cxx:2588: warning: comparison is always true due to limited range
of data type

Please fix this.
-- 
Pavel Janík




Mime
View raw message