incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pavel Janík <pa...@janik.cz>
Subject Fwd: [Bug 120179] New: WaE: sc/source/filter/excel/excform.cxx
Date Tue, 14 Aug 2012 13:41:18 GMT
Please review the patch.

Begin forwarded message:

> From: bugzilla@apache.org
> Date: July 3, 2012 6:33:45 PM GMT+02:00
> To: pavel@janik.cz
> Subject: [Bug 120179] New: WaE: sc/source/filter/excel/excform.cxx
> 
> https://issues.apache.org/ooo/show_bug.cgi?id=120179
> 
>          Priority: P3
>            Bug ID: 120179
>          Assignee: ooo-issues@incubator.apache.org
>           Summary: WaE: sc/source/filter/excel/excform.cxx
>          Severity: normal
>        Issue Type: DEFECT
>    Classification: Application
>                OS: All
>          Reporter: pavel@janik.cz
>          Hardware: All
>            Status: CONFIRMED
>           Version: AOO 3.4.0
>         Component: code
>           Product: spreadsheet
> 
> Current trunk:
> 
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sc/source/filter/excel/excform.cxx:
> In function ‘sal_Bool lcl_isInMissArgForZeroList(DefTokenId)’:
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sc/source/filter/excel/excform.cxx:1553:
> warning: comparison between signed and unsigned integer expressions
> 
> Proposed change:
> 
> diff -ur sc.orig/source/filter/excel/excform.cxx
> sc/source/filter/excel/excform.cxx
> --- sc.orig/source/filter/excel/excform.cxx     2012-07-03 14:41:38.000000000
> +0200
> +++ sc/source/filter/excel/excform.cxx  2012-07-03 14:42:16.000000000 +0200
> @@ -1550,7 +1550,7 @@
> 
> sal_Bool lcl_isInMissArgForZeroList(DefTokenId id)
> {
> -       for(short index = 0; index < missArgForZeroCount; index++)
> +       for(DefTokenId index = 0; index < missArgForZeroCount; index++)
>                if(missArgForZeroList[index] == id)
>                        return sal_True;
>        return sal_False;
> 
> -- 
> You are receiving this mail because:
> You reported the bug.

-- 
Pavel Janík




Mime
View raw message