Return-Path: 
 <ooo-dev-return-22622-apmail-incubator-ooo-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id DE91EDE1C
	for <apmail-incubator-ooo-dev-archive@minotaur.apache.org>;
 Mon,  9 Jul 2012 07:26:19 +0000 (UTC)
Received: (qmail 12080 invoked by uid 500); 9 Jul 2012 07:26:19 -0000
Delivered-To: apmail-incubator-ooo-dev-archive@incubator.apache.org
Received: (qmail 11969 invoked by uid 500); 9 Jul 2012 07:26:19 -0000
Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:ooo-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:ooo-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:ooo-dev@incubator.apache.org>
List-Id: <ooo-dev.incubator.apache.org>
Reply-To: ooo-dev@incubator.apache.org
Delivered-To: mailing list ooo-dev@incubator.apache.org
Received: (qmail 11874 invoked by uid 99); 9 Jul 2012 07:26:19 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jul 2012 07:26:19 +0000
X-ASF-Spam-Status: No, hits=1.7 required=5.0
	tests=FREEMAIL_ENVFROM_END_DIGIT,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of shanzhu33@gmail.com designates
 209.85.213.175 as permitted sender)
Received: from [209.85.213.175] (HELO mail-yx0-f175.google.com)
 (209.85.213.175)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jul 2012 07:26:11 +0000
Received: by yenl13 with SMTP id l13so9120127yen.6
        for <multiple recipients>; Mon, 09 Jul 2012 00:25:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:date:message-id:subject:from:to:content-type;
        bh=S/eH+J1fx51oZq1FPEPrVd3GRhQqMjk6c/r7SvxxI+0=;
        b=FakieDwCRtUWjHv1As3+MWpcNIeuk1J7Ju5D3+e21qBnAonOblq57zbE426rCt7cTh
         IHz0a5++7u8aXYF/aTlq3BPqyOyCU2T/RgPzQZKpIlzKkP4ICYleCWfhGGfnnVq97nSI
         8TawegQS8MJKkDSra55O4K31n9izBB5y5c3CpUDvoUowH7PW3+bYJwLjQ6OiN9Hlkep6
         j80fB56h44hNsMmiStODEL9zQ/MKdNbJcCNEMjZYH/lAc1LQS1XSgDTBYEsDWOlBgND/
         N3RlPFNhT5KmwoHXc653q5c7VRANAfgDjVANdhH3j0N7jaYdhfVXjCZ7l6ghxbMzOPqC
         AHZA==
MIME-Version: 1.0
Received: by 10.66.84.71 with SMTP id w7mr63592299pay.33.1341818750161; Mon,
 09 Jul 2012 00:25:50 -0700 (PDT)
Received: by 10.68.229.74 with HTTP; Mon, 9 Jul 2012 00:25:50 -0700 (PDT)
Date: Mon, 9 Jul 2012 15:25:50 +0800
Message-ID: 
 <CAJb-7cn062QfKtp2vRaXPGKV-qFRht10A_yxAT5dVrvFkjc1eA@mail.gmail.com>
Subject: [QA AUTOMATION][Proposal]Suggest to group definition of UI Controls
 in UIMap.java.
From: Shan Zhu <shanzhu33@gmail.com>
To: ooo-dev@incubator.apache.org, ooo-qa@incubator.apache.org
Content-Type: multipart/alternative; boundary=f46d042f952ef4d11504c460854f

--f46d042f952ef4d11504c460854f
Content-Type: text/plain; charset=ISO-8859-1

Hi, all

In VCLAuto, we define the UI controls used in our script in UIMap.java.
Now, there is a long disordered list of UI controls, which will continue to
grow up.
For readability, I propose to group the definition of controls by Editor
and dialogs.

1. Put the definition of controls in same editor together, with a comment
line at the front to declare the editor name.
2. Put the definition of controls in same dialog together, with a comment
line to declare the dialog name.
    It would be better that if the sequence of the definition for a dialog
could  following the UI arrangement in dialog.
For example,
// Spreadsheet: "Select Sheets" dialog
public static final VclDialog SCSelectSheetsDlg =
dialog(".uno:SelectTables");
...
// Spreasheet: "Sort" dialog
...
Moreover,  suggest to add definition for other controls in one dialog, even
you've used few of them in your script writing.
And, a basic rule for variable name definition is needed, if necessary.

Regards,
Shan Zhu

--f46d042f952ef4d11504c460854f--