incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From J├╝rgen Schmidt <jogischm...@googlemail.com>
Subject Re: trunk build breaks in qadevOOo because of missing class TextFitToSizeType
Date Mon, 30 Jul 2012 07:16:35 GMT
On 7/28/12 11:57 PM, Ariel Constenla-Haile wrote:
> Hi Regina,
> 
> On Sat, Jul 28, 2012 at 6:41 AM, Regina Henschel
> <rb.henschel@t-online.de> wrote:
>> Hi,
>>
>> I start to build trunk with MSVC Express on WinXP. The build breaks in
>> qadevOOo with error message
>>
>> C:\AOO_2012_07_git\trunk\main\qadevOOo\runner\util\ValueChanger.java:378:
>> cannot find symbol
>> symbol  : class TextFitToSizeType
>> location: package com.sun.star.drawing
>>     if (oldValue instanceof com.sun.star.drawing.TextFitToSizeType){
>>                                                 ^
>> Reason seems to be, that the changes in
>>   r1366087: #116001# TextToFitSize item/property optimized to boolean
>> are incomplete.
> 
> IMHO besides of being incomplete, they are incompatible, and thus the
> API changes should be reverted: this kind of incompatible API changes
> should happen only on mayor versions, they should wait for AOO 4; in
> the meantime, the solution seems to be:

in general yes and I woudl agree but in this case Armin told me that the
implementation was always different and the IDL was wrong. We did such
changes in the past as well but always very seldom and carefully.

It doesn't help to keep wrong IDL types that never have worked and were
not really used. The mistake that was made here is to forget a clean
build from scratch and solve all code places accordingly. That has to be
solved.

Juergen

> 
> * Removed: incubator/ooo/trunk/main/offapi/com/sun/star/drawing/TextFitToSizeType.idl
>   com.sun.star.drawing.TextFitToSizeType was removed from module
> offapi but it was published API, thus it shouldn't be removed, but
> deprecated
> 
> * Modified:  incubator/ooo/trunk/main/offapi/com/sun/star/drawing/TextProperties.idl
>   The type of TextFitToSize cannot be changed because it is a
> published service, it should be tagged as deprecated, and a new
> property should be introduced instead, something like [property]
> boolean FitTextToSize; tagged as optional, because the service is
> published.
> 
> In order to fix the build breaker you'll have to do more than just
> reintroduce TextFitToSizeType.idl in offapi. The removal was also
> incomplete, opengroking TextFitToSizeType shows that:
> http://opengrok.adfinis-sygroup.org/source/search?q=TextFitToSizeType&defs=&refs=&path=&hist=&project=aoo-trunk
> 
> binfilter is breaking too (this module is built by default in trunk,
> until we decide to deprecate/remove it).
> 
> In file included from
> /build/aoo/src/playground/trunk/main/binfilter/bf_svx/source/unoedit/svx_unotext.cxx:71:0:
> ../../../inc/bf_svx/unoshprp.hxx:76:54: fatal error:
> com/sun/star/drawing/TextFitToSizeType.hpp: No such file or directory
> compilation terminated.
> In file included from
> /build/aoo/src/playground/trunk/main/binfilter/bf_sch/source/ui/unoidl/sch_mapprov.cxx:40:0:
> ../../../../inc/bf_svx/unoshprp.hxx:76:54: fatal error:
> com/sun/star/drawing/TextFitToSizeType.hpp: No such file or directory
> compilation terminated.
> In file included from
> /build/aoo/src/playground/trunk/main/binfilter/bf_sch/source/ui/unoidl/sch_ChXDataPoint.cxx:36:0:
> ../../../../inc/bf_svx/unoshprp.hxx:76:54: fatal error:
> com/sun/star/drawing/TextFitToSizeType.hpp: No such file or directory
> compilation terminated.
> In file included from
> /build/aoo/src/playground/trunk/main/binfilter/bf_sch/source/ui/unoidl/sch_ChXDataRow.cxx:37:0:
> ../../../../inc/bf_svx/unoshprp.hxx:76:54: fatal error:
> com/sun/star/drawing/TextFitToSizeType.hpp: No such file or directory
> compilation terminated.
> In file included from
> /build/aoo/src/playground/trunk/main/binfilter/bf_sch/source/ui/unoidl/sch_ChXChartObject.cxx:36:0:
> ../../../../inc/bf_svx/unoshprp.hxx:76:54: fatal error:
> com/sun/star/drawing/TextFitToSizeType.hpp: No such file or directory
> compilation terminated.
> In file included from
> /build/aoo/src/playground/trunk/main/binfilter/bf_sch/source/ui/unoidl/sch_ChXChartAxis.cxx:59:0:
> ../../../../inc/bf_svx/unoshprp.hxx:76:54: fatal error:
> com/sun/star/drawing/TextFitToSizeType.hpp: No such file or directory
> compilation terminated.
> dmake:  Error code 1, while making
> '../../../../unxlngx6/slo/sch_ChXDataPoint.obj'
> dmake:  Error code 1, while making '../../../unxlngx6/slo/svx_unotext.obj'
> ERROR: error 65280 occurred while making
> /build/aoo/src/playground/trunk/main/binfilter/bf_svx/source/unoedit
> ERROR: error 65280 occurred while making
> /build/aoo/src/playground/trunk/main/binfilter/bf_svx/source/svdraw
> ERROR: error 65280 occurred while making
> /build/aoo/src/playground/trunk/main/binfilter/bf_sch/source/ui/unoidl
> 
> 
> Regards
> 


Mime
View raw message