incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From J├╝rgen Schmidt <jogischm...@googlemail.com>
Subject Coding guideline or common rules
Date Fri, 20 Jul 2012 10:14:33 GMT
Hi,

I just stumbled over a commit message for the new UOF filter.

I think we should agree on a common guideline for our code and how we
contribute changes and bring them in the code.

SCM's manage the change sets and the information who made the change,
that means we don't need further comments like this

///Begin Added by wangyumin for uof2-filter from cs2c
...
/// End Added by wangyumin on 2012-2-22 14:32:18

It is somewhat redundant and makes the code not really better readable.
Can we agree on the common understanding that we don't need such
comments and that we don't want them in the code. We should remove such
comments wherever we see or find them.

Don't get me wrong, my intention is to keep the code better readable ;-)

Any opinions?

Juergen


See for example:
--- incubator/ooo/trunk/main/scp2/source/ooo/directory_ooo.scp (original)
+++ incubator/ooo/trunk/main/scp2/source/ooo/directory_ooo.scp Fri Jul
20 08:24:50 2012
@@ -420,6 +420,16 @@ Directory gid_Dir_Share_Xslt_Import_uof
     ParentID = gid_Dir_Share_Xslt_Import;
     DosName = "uof";
 End
+///Begin Added by wangyumin for uof2-filter from cs2c
yumin.wang@cs2c.com.cn on 2012-2-22 14:32:18
+Directory gid_Dir_Share_Xslt_Export_uof2
+    ParentID = gid_Dir_Share_Xslt_Export;
+    DosName = "uof2";
+End
+Directory gid_Dir_Share_Xslt_Import_uof2
+    ParentID = gid_Dir_Share_Xslt_Import;
+    DosName = "uof2";
+End
+/// End Added by wangyumin on 2012-2-22 14:32:18
 Directory gid_Dir_Share_Xslt_Export_Wordml
     ParentID = gid_Dir_Share_Xslt_Export;
     DosName = "wordml";

Mime
View raw message