incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From J├╝rgen Schmidt <jogischm...@googlemail.com>
Subject Re: [call-for-review][3.4.1]bug 120029 - All GlobalAcceleratorConfiguration objects get leaked
Date Mon, 02 Jul 2012 13:21:51 GMT
On 6/20/12 3:38 PM, zhangjf wrote:
> Thank you.
> 
> On Wed, Jun 20, 2012 at 8:40 PM, Andre Fischer <af@a-w-f.de> wrote:
>> Review done.
>>
>> -Andre
>>
>>
>> On 20.06.2012 14:02, zhangjf wrote:
>>>
>>> Hi,
>>>
>>> I filed a memory leak bug
>>> https://issues.apache.org/ooo/show_bug.cgi?id=120029 and have provided
>>> a fix patch for it. The problem is on framework
>>> GlobalAcceleratorConfiguration objects leak created by toolbarmanager
>>> and menubarmanager. Can someone help to review it?
>>>
>>> This leak happens with very common use cases, such as new/open a
>>> document to show the toolbar, or mouse click to show the drop down
>>> menu. I suspect it is one of the reason which caused memory incease
>>> reported by liu zhe in post http://s.apache.org/00R. So I propose to
>>> put it's fix into 3.4.1 too once it passes review. Any objections?

+1 for including it in 3.4.1

Juergen

Mime
View raw message