Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ooo-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of zheng.easyfan@gmail.com
 designates 209.85.160.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4FE080DB.5050406@googlemail.com>
References: 
 <CAP-ksogko9467Af8VNPrQWecUO_1KQtcrAiPke51CRR1ELJxuw@mail.gmail.com>
	<4FE080DB.5050406@googlemail.com>
Date: Mon, 25 Jun 2012 16:20:32 +0800
Message-ID: 
 <CALHC_o0HZ3V420g42C4y2pE3B8WYrPO+M69-bhGNNjnrQJhydA@mail.gmail.com>
Subject: Re: Propose for 3.4.1: Can't remove password from file (119366)
From: Fan Zheng <zheng.easyfan@gmail.com>
To: ooo-dev@incubator.apache.org
Content-Type: multipart/alternative; boundary=20cf300face7cc837104c347a76d

--20cf300face7cc837104c347a76d
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi, All:

This issue was solved, now call for the reviewers.

In general, this is a setting confusion issue. In current saving process,
both SID_ENCRYPTIONDATA and SID_PASSWORD are working for setting password
on a document.
Refer to the SfxObjectShell::ExecFile_Impl() in file
SRC/sfx2/source/doc/objserv.cxx:line 595-599 please.
And, as what we imagine, after doing the file dialog executing with
deselecting the check box of "Save with password", the result parameter
set, which is to customize saving process, wont record said 2 SID inside
anymore, for indicating that the following saving process will not concern
about the password stuff anymore.
But when performing the exact preparation SaveAs process in
SfxobjectShell::PreDoSaveAs_impl(), only the the default SID_PASSWORD was
cleared, but  SID_ENCRYPTIONDATA  was not. The issue happens.

For solving it, we just simply add the item SID_ENCRYPTIONDATA  clearing
in  SfxobjectShell::PreDoSaveAs_impl(), similar as the SID_PASSWORD.


2012/6/19 J=FCrgen Schmidt <jogischmidt@googlemail.com>

> On 6/18/12 1:16 AM, Rob Weir wrote:
> > https://issues.apache.org/ooo/show_bug.cgi?id=3D119366
> >
> > This is a regression introduced in OOo 3.4 beta but not detected in
> > AOO 3.4 tested.   Once a password is set it cannot be removed.  Two
> > users have reported it.
> >
> > -Rob
> >
> can we agree on subject line like
>
> [RELEASE][3.4.1]: ....
>
> that makes it easier to track all release relevant things
>
>
> +1 for this issue
>
> Juergen
>
>
>

--20cf300face7cc837104c347a76d--