Return-Path: X-Original-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F2F139EFA for ; Wed, 20 Jun 2012 13:38:47 +0000 (UTC) Received: (qmail 55545 invoked by uid 500); 20 Jun 2012 13:38:47 -0000 Delivered-To: apmail-incubator-ooo-dev-archive@incubator.apache.org Received: (qmail 55448 invoked by uid 500); 20 Jun 2012 13:38:47 -0000 Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ooo-dev@incubator.apache.org Delivered-To: mailing list ooo-dev@incubator.apache.org Received: (qmail 55440 invoked by uid 99); 20 Jun 2012 13:38:47 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jun 2012 13:38:47 +0000 Received: from localhost (HELO mail-pb0-f47.google.com) (127.0.0.1) (smtp-auth username zhangjf, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jun 2012 13:38:47 +0000 Received: by pbbrq2 with SMTP id rq2so612175pbb.6 for ; Wed, 20 Jun 2012 06:38:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.219.162 with SMTP id pp2mr76177135pbc.85.1340199526846; Wed, 20 Jun 2012 06:38:46 -0700 (PDT) Received: by 10.68.235.105 with HTTP; Wed, 20 Jun 2012 06:38:46 -0700 (PDT) In-Reply-To: <4FE1C4D1.6060402@a-w-f.de> References: <4FE1C4D1.6060402@a-w-f.de> Date: Wed, 20 Jun 2012 21:38:46 +0800 Message-ID: Subject: Re: [call-for-review][3.4.1]bug 120029 - All GlobalAcceleratorConfiguration objects get leaked From: zhangjf To: ooo-dev@incubator.apache.org Content-Type: text/plain; charset=ISO-8859-1 Thank you. On Wed, Jun 20, 2012 at 8:40 PM, Andre Fischer wrote: > Review done. > > -Andre > > > On 20.06.2012 14:02, zhangjf wrote: >> >> Hi, >> >> I filed a memory leak bug >> https://issues.apache.org/ooo/show_bug.cgi?id=120029 and have provided >> a fix patch for it. The problem is on framework >> GlobalAcceleratorConfiguration objects leak created by toolbarmanager >> and menubarmanager. Can someone help to review it? >> >> This leak happens with very common use cases, such as new/open a >> document to show the toolbar, or mouse click to show the drop down >> menu. I suspect it is one of the reason which caused memory incease >> reported by liu zhe in post http://s.apache.org/00R. So I propose to >> put it's fix into 3.4.1 too once it passes review. Any objections? >> >> Regards, >> zhangjf >> >