Return-Path: X-Original-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5F8699EDC for ; Thu, 28 Jun 2012 13:04:25 +0000 (UTC) Received: (qmail 45593 invoked by uid 500); 28 Jun 2012 13:04:25 -0000 Delivered-To: apmail-incubator-ooo-dev-archive@incubator.apache.org Received: (qmail 45385 invoked by uid 500); 28 Jun 2012 13:04:24 -0000 Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ooo-dev@incubator.apache.org Delivered-To: mailing list ooo-dev@incubator.apache.org Received: (qmail 45369 invoked by uid 99); 28 Jun 2012 13:04:24 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jun 2012 13:04:24 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of debin.lei@gmail.com designates 209.85.214.47 as permitted sender) Received: from [209.85.214.47] (HELO mail-bk0-f47.google.com) (209.85.214.47) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jun 2012 13:04:19 +0000 Received: by bkcjm2 with SMTP id jm2so1810110bkc.6 for ; Thu, 28 Jun 2012 06:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=0x0m6TWrWZOm/O7u6pCp5GJ/Gw9++1P9563cgkukLwU=; b=tqVcQh8KK94vDX/5rLRG8/jpUQPVa3zb3+ENpkSCJ2DIUFbtRKCpOl2DwkiYrgaLRn W7SwHXEU/CvaNwPSwz0vBple3YWJXjApGgxr+Ey/bzKYy8FGB6dLgBMEtUzVwaJyQ41r UfaiKN3zjtuOmOXZbu5PSQJU3BjqXZ4rDKMTuF1Uah8RMMyknJ3viB6XcQUSXqBpAvWx z0TvySmGK0KFwgGheE1JSRHud+e1+PS4jk+5zQhtJcW1FDRSVVB3lLiRxH0hnabnN7L8 Z7wqtnOvsVrkFOi3Pm94KQKdJayP2TjxYMC4gUojOU/4XEZeF3OACmDlJsCXlE3qAIIc /l5g== MIME-Version: 1.0 Received: by 10.152.102.234 with SMTP id fr10mr2105010lab.32.1340888638284; Thu, 28 Jun 2012 06:03:58 -0700 (PDT) Received: by 10.112.81.98 with HTTP; Thu, 28 Jun 2012 06:03:58 -0700 (PDT) In-Reply-To: <4FEC23AE.2080906@googlemail.com> References: <4FEAB273.9030507@googlemail.com> <4FEC23AE.2080906@googlemail.com> Date: Thu, 28 Jun 2012 21:03:58 +0800 Message-ID: Subject: Re: [Discussion]Active Doc/Sheet protection password related blocks From: De Bin Lei To: ooo-dev@incubator.apache.org Content-Type: multipart/alternative; boundary=f46d04071259f7e26f04c387f6f2 X-Virus-Checked: Checked by ClamAV on apache.org --f46d04071259f7e26f04c387f6f2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable 2012/6/28 J=FCrgen Schmidt > On 6/28/12 11:14 AM, Steve Yin wrote: > > Hi all, > > > > This feature has been tested and enabled in Symphony over 2 years. It > does > > work. And The hash algorithm is correct. I remember Kohei's aim was to > > implement almost all protection features like MS Excel includes differe= nt > > privileges. One possible reason is the current implementation is not > > complete for Kohei, So he disable the feature by default at that time. > > However. I think we can enable it safely now. > > we should track it then as a new feature for 3.5. I suggest that we > create a feature task for it. > > Thank you for your suggestion, I will help to track it as a feature and commit the code. > Juergen > > > > > On Thu, Jun 28, 2012 at 3:35 PM, Lei Wang > wrote: > > > >> Hi Jian Yuan, > >> > >> The file tabprotection.hxx is created by CWS scheetprotection02. I go > >> through the comments when this CWS integrated into the trunk. But I do > not > >> find any useful information. > >> > >> If Excel use another hash algorithm, AOO can not unprotect the sheet/d= oc > >> even user input the right password. To avoid this bad situation, I gue= ss > >> the developer disable related function. > >> > >> On Wed, Jun 27, 2012 at 3:12 PM, Oliver-Rainer Wittmann < > >> orwittmann@googlemail.com> wrote: > >> > >>> Hi, > >>> > >>> > >>> On 26.06.2012 08:44, Jianyuan Li wrote: > >>> > >>>> Hi, all, > >>>> > >>>> In ../sc/inc/tabprotection.hxx, a macro is defined as below: > >>>> #define ENABLE_SHEET_PROTECTION 0 > >>>> > >>>> So all blocks controlled by it will not be executed: > >>>> 1. Import/export Sheet/Doc protection password for a protected xls > file. > >>>> 2. Import a protected xls file and show unpassword dlg to input > password > >>>> when unprotect the sheet/doc. > >>>> 2. Import a ods/xls file and export it as a xls/ods file. Show > password > >>>> retype dlg. > >>>> And there is an issue related to it: > >>>> https://issues.apache.org/ooo/**show_bug.cgi?id=3D119552< > >> https://issues.apache.org/ooo/show_bug.cgi?id=3D119552>. > >>>> I have added some > >>>> comments for it. > >>>> I had a simple test to set the macro as 1 and checked all above > >> scenarios. > >>>> It works well. So here I want to set the macro as 1. > >>>> > >>>> Any comments? Or does anyone know the initial thought for the value > "0" > >>>> of ENABLE_SHEET_PROTECTION? > >>>> > >>>> > >>> I do not know anything about this code. > >>> > >>> But may be a look in the hg repository - still available at [1] - wou= ld > >>> help. May be the one or the other commit log message by which this > macro > >>> has been introduced would give some answers. > >>> > >>> [1] http://hg.services.openoffice.**org/< > >> http://hg.services.openoffice.org/> > >>> > >>> > >>> Best regards, Oliver. > >>> > >> > > > > > > > > > --=20 Best regards Lei De Bin --f46d04071259f7e26f04c387f6f2--