Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ooo-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of jogischmidt@googlemail.com
 designates 209.85.214.47 as permitted sender)
Message-ID: <4FEC23AE.2080906@googlemail.com>
Date: Thu, 28 Jun 2012 11:28:14 +0200
From: =?ISO-8859-1?Q?J=FCrgen_Schmidt?= <jogischmidt@googlemail.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: ooo-dev@incubator.apache.org
Subject: Re: [Discussion]Active Doc/Sheet protection password related blocks
References: 
 <CAPNWwk3MufjXcOwWM+vMYVaE+=WHN1g361EdKx=CKH+LpHgjjA@mail.gmail.com>
 <4FEAB273.9030507@googlemail.com>
 <CA+mMfTf_=jmBHfdnD=0n2xXEbRJfgNQ1OdK8ze7y84XZwY_jRQ@mail.gmail.com>
 <CALcesKA2bYYt0byfwrBb4OOCpxOMALz6yst7H5DsOr-HoWT_HQ@mail.gmail.com>
In-Reply-To: 
 <CALcesKA2bYYt0byfwrBb4OOCpxOMALz6yst7H5DsOr-HoWT_HQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

On 6/28/12 11:14 AM, Steve Yin wrote:
> Hi all,
> 
> This feature has been tested and enabled in Symphony over 2 years. It does
> work. And The hash algorithm is correct. I remember Kohei's aim was to
> implement almost all protection features like MS Excel includes different
> privileges. One possible reason is the current implementation is not
> complete for Kohei, So he disable the feature by default at that time.
> However. I think we can enable it safely now.

we should track it then as a new feature for 3.5. I suggest that we
create a feature task for it.

Juergen

> 
> On Thu, Jun 28, 2012 at 3:35 PM, Lei Wang <lei.wang.leiw@gmail.com> wrote:
> 
>> Hi Jian Yuan,
>>
>> The file tabprotection.hxx is created by CWS scheetprotection02. I go
>> through the comments when this CWS integrated into the trunk. But I do not
>> find any useful information.
>>
>> If Excel use another hash algorithm, AOO can not unprotect the sheet/doc
>> even user input the right password. To avoid this bad situation, I guess
>> the developer disable related function.
>>
>> On Wed, Jun 27, 2012 at 3:12 PM, Oliver-Rainer Wittmann <
>> orwittmann@googlemail.com> wrote:
>>
>>> Hi,
>>>
>>>
>>> On 26.06.2012 08:44, Jianyuan Li wrote:
>>>
>>>> Hi, all,
>>>>
>>>> In ../sc/inc/tabprotection.hxx, a macro is defined as below:
>>>> #define ENABLE_SHEET_PROTECTION 0
>>>>
>>>> So all blocks controlled by it will not be executed:
>>>> 1. Import/export Sheet/Doc protection password for a protected xls file.
>>>> 2. Import a protected xls file and show unpassword dlg to input password
>>>> when unprotect the sheet/doc.
>>>> 2. Import a ods/xls file and export it as a xls/ods file. Show password
>>>> retype dlg.
>>>> And there is an issue related to it:
>>>> https://issues.apache.org/ooo/**show_bug.cgi?id=119552<
>> https://issues.apache.org/ooo/show_bug.cgi?id=119552>.
>>>> I have added some
>>>> comments for it.
>>>> I had a simple test to set the macro as 1 and checked all above
>> scenarios.
>>>> It works well. So here I want to set the macro as 1.
>>>>
>>>> Any comments? Or does anyone know the initial thought for the value "0"
>>>> of ENABLE_SHEET_PROTECTION?
>>>>
>>>>
>>> I do not know anything about this code.
>>>
>>> But may be a look in the hg repository - still available at [1] - would
>>> help. May be the one or the other commit log message by which this macro
>>> has been introduced would give some answers.
>>>
>>> [1] http://hg.services.openoffice.**org/<
>> http://hg.services.openoffice.org/>
>>>
>>>
>>> Best regards, Oliver.
>>>
>>
> 
> 
>