Return-Path: X-Original-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0E742CEDA for ; Fri, 22 Jun 2012 07:31:08 +0000 (UTC) Received: (qmail 48497 invoked by uid 500); 22 Jun 2012 07:31:07 -0000 Delivered-To: apmail-incubator-ooo-dev-archive@incubator.apache.org Received: (qmail 48436 invoked by uid 500); 22 Jun 2012 07:31:07 -0000 Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ooo-dev@incubator.apache.org Delivered-To: mailing list ooo-dev@incubator.apache.org Received: (qmail 48423 invoked by uid 99); 22 Jun 2012 07:31:07 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jun 2012 07:31:07 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of orwittmann@googlemail.com designates 209.85.214.47 as permitted sender) Received: from [209.85.214.47] (HELO mail-bk0-f47.google.com) (209.85.214.47) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jun 2012 07:31:01 +0000 Received: by bkcjm2 with SMTP id jm2so1237466bkc.6 for ; Fri, 22 Jun 2012 00:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=fT5atw/LhijWqsG2fC5z3O4M4swBA7my1NfSx5QwlPM=; b=qkjKoREHnD74H+zIHs69XVEV2ucvG8nQ+objHOBDFxEzGsz3D1cYpS3mi33Joz2Feb +OhWiC6FcY2zDDjdvyTbwIUAx8/cSVOVKH0Y8COQYAXclEtBrZ1nFy0YUJQll2GDJ5/B gus5wtU7Qczxd58UVF+nEBd8ZFRGj5RQxDXWFnr5FHlE21sP0LBZnwJMC82raIDW+vAD zkEbf4fdp9CWCB0k8LDF36lgpnCbY3D1joiKyOmfmgw6PPqmLQxNP+sq9ihPkZLM8IIM aD93sDq2P+xKAstw/mCLi010pKZRITlRttReN3W4ZH894EZ1ptCunDTxWgxe8UR5yrlX QzHQ== Received: by 10.205.128.3 with SMTP id hc3mr382085bkc.29.1340350239602; Fri, 22 Jun 2012 00:30:39 -0700 (PDT) Received: from [192.168.2.110] (p548CC6EB.dip.t-dialin.net. [84.140.198.235]) by mx.google.com with ESMTPS id n17sm34844647bkw.5.2012.06.22.00.30.37 (version=SSLv3 cipher=OTHER); Fri, 22 Jun 2012 00:30:38 -0700 (PDT) Message-ID: <4FE41F21.2080008@googlemail.com> Date: Fri, 22 Jun 2012 09:30:41 +0200 From: Oliver-Rainer Wittmann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: ooo-dev@incubator.apache.org Subject: Re: [Call for Review] Issue 119945 - Application crashed if undo adding caption to drawing object in sw References: <4FE31A7D.8020602@googlemail.com> In-Reply-To: <4FE31A7D.8020602@googlemail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Hi, On 21.06.2012 14:58, Oliver-Rainer Wittmann wrote: > Hi, > > On 14.06.2012 15:22, Lin Yuan wrote: >> I have submit a patch to fix issue 119945. It's a crash issue when user do >> "group","ungroup","add caption" operations for two drawing objects and then >> do undo. >> >> Detail issue info and comments of this issue please refer to >> https://issues.apache.org/ooo/show_bug.cgi?id=119945 >> Patch info please refer to >> https://issues.apache.org/ooo/attachment.cgi?id=78310 >> >> Please help review this fix. Thanks. >> > > I am taking over the issue to review the patch. > Patch works fine --> applied to trunk, revision 1352786 Thx for the patch, Oliver.