Return-Path: X-Original-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 890D09E74 for ; Fri, 22 Jun 2012 06:45:36 +0000 (UTC) Received: (qmail 49241 invoked by uid 500); 22 Jun 2012 06:45:35 -0000 Delivered-To: apmail-incubator-ooo-dev-archive@incubator.apache.org Received: (qmail 49057 invoked by uid 500); 22 Jun 2012 06:45:35 -0000 Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ooo-dev@incubator.apache.org Delivered-To: mailing list ooo-dev@incubator.apache.org Received: (qmail 49045 invoked by uid 99); 22 Jun 2012 06:45:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jun 2012 06:45:34 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [71.74.56.122] (HELO hrndva-omtalb.mail.rr.com) (71.74.56.122) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jun 2012 06:45:26 +0000 X-Authority-Analysis: v=2.0 cv=eIiRfQV1 c=1 sm=0 a=/5O+cGqw+0vue3E/hLuuyQ==:17 a=8gaiDk37JdsA:10 a=aZEDvWa5QNkA:10 a=HQHU1wNLd14A:10 a=cX0H9CLn-QkA:10 a=jPJDawAOAc8A:10 a=aFGVzZ1oTV0A:10 a=IkcTkHD0fZMA:10 a=XHYATe7NAAAA:8 a=mV9VRH-2AAAA:8 a=aJtXiF-JnZu7PYUVdVoA:9 a=QEXdDO2ut3YA:10 a=HFtHcI9Jw8gA:10 a=/5O+cGqw+0vue3E/hLuuyQ==:117 X-Cloudmark-Score: 0 X-Originating-IP: 107.10.145.191 Received: from [107.10.145.191] ([107.10.145.191:56627] helo=[10.5.0.2]) by hrndva-oedge02.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id F5/C4-15196-07414EF4; Fri, 22 Jun 2012 06:45:04 +0000 Message-ID: <4FE41470.4040003@pitonyak.org> Date: Fri, 22 Jun 2012 02:45:04 -0400 From: Andrew Douglas Pitonyak Reply-To: andrew@pitonyak.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: ooo-dev@incubator.apache.org Subject: Re: =?UTF-8?B?W0NhbGwtZm9yLeKAi1Jldmlld10gb25lIGZpeCBmb3Igb2R0IHM=?= =?UTF-8?B?YXZpbmcgcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnQ=?= References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/21/2012 01:00 AM, li zhang wrote: > hi, all > I'm zhang li from China. My main focus is performance(loading, saving, > asynchronous loading, etc). > > I have one fix need for review. It is about odt saving. Please check the > below for details, thanks! > > https://issues.apache.org/ooo/show_bug.cgi?id=120030 > > root cause: > Do profiling on a sample file, SfxObjectShell::GenerateAndStoreThumbnail is > to be found occypy too much time, and it will call SwFlyFrm::Paint several > times, but it's unnecessary to paint thumbnail so many times when saving. > > solution: > When thumbnail is generated and stored, in SwFlyFrm::Paint, current visible > rectangle will be compared with fly frame rectangle, if the two rectangles > don't intersect, SwFlyFrm::Paint will return, need no repaint. > Excellent.... I hope this speeds up the save time on http://www.pitonyak.org/OOME_3_0.odt Document loads pretty fast, but saving is horrid! Do you have a link for more information related to "how to profile OOo"? -- Andrew Pitonyak My Macro Document: http://www.pitonyak.org/AndrewMacro.odt Info: http://www.pitonyak.org/oo.php