Return-Path: X-Original-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E45FE9CF9 for ; Wed, 20 Jun 2012 12:41:33 +0000 (UTC) Received: (qmail 87630 invoked by uid 500); 20 Jun 2012 12:41:32 -0000 Delivered-To: apmail-incubator-ooo-dev-archive@incubator.apache.org Received: (qmail 87413 invoked by uid 500); 20 Jun 2012 12:41:32 -0000 Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ooo-dev@incubator.apache.org Delivered-To: mailing list ooo-dev@incubator.apache.org Received: (qmail 87384 invoked by uid 99); 20 Jun 2012 12:41:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jun 2012 12:41:31 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [87.253.162.5] (HELO server5.configcenter.info) (87.253.162.5) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jun 2012 12:41:22 +0000 Received: from [9.155.131.113] (deibp9eh1--blueice3n2.emea.ibm.com [195.212.29.180]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: web445p1) by server5.configcenter.info (Postfix) with ESMTP id 58DF51BB0DE0 for ; Wed, 20 Jun 2012 14:40:57 +0200 (CEST) Message-ID: <4FE1C4D1.6060402@a-w-f.de> Date: Wed, 20 Jun 2012 14:40:49 +0200 From: Andre Fischer User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: ooo-dev@incubator.apache.org Subject: Re: [call-for-review][3.4.1]bug 120029 - All GlobalAcceleratorConfiguration objects get leaked References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0 (server5.configcenter.info [0.0.0.0]); Wed, 20 Jun 2012 14:40:57 +0200 (CEST) X-server5-MailScanner-Information: Please contact the ISP for more information X-MailScanner-ID: 58DF51BB0DE0.A3864 X-server5-MailScanner: Found to be clean X-server5-MailScanner-From: af@a-w-f.de X-Old-Spam-Status: No Review done. -Andre On 20.06.2012 14:02, zhangjf wrote: > Hi, > > I filed a memory leak bug > https://issues.apache.org/ooo/show_bug.cgi?id=120029 and have provided > a fix patch for it. The problem is on framework > GlobalAcceleratorConfiguration objects leak created by toolbarmanager > and menubarmanager. Can someone help to review it? > > This leak happens with very common use cases, such as new/open a > document to show the toolbar, or mouse click to show the drop down > menu. I suspect it is one of the reason which caused memory incease > reported by liu zhe in post http://s.apache.org/00R. So I propose to > put it's fix into 3.4.1 too once it passes review. Any objections? > > Regards, > zhangjf >