Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ooo-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of jogischmidt@googlemail.com
 designates 209.85.212.177 as permitted sender)
Message-ID: <4FE15D68.1000800@googlemail.com>
Date: Wed, 20 Jun 2012 07:19:36 +0200
From: =?UTF-8?B?SsO8cmdlbiBTY2htaWR0?= <jogischmidt@googlemail.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:13.0) Gecko/20120601 Thunderbird/13.0
MIME-Version: 1.0
To: ooo-dev@incubator.apache.org
Subject: Re: svn commit: r1351633 - in /incubator/ooo/trunk/main:
 instsetoo_native/util/openoffice.lst
 solenv/inc/version.lst sysui/desktop/productversion.mk
References: <20120619100016.43BB62388EA1@eris.apache.org>
 <4FE0DBF2.2090503@wtnet.de>
In-Reply-To: <4FE0DBF2.2090503@wtnet.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 6/19/12 10:07 PM, Marcus (OOo) wrote:
> Am 06/19/2012 12:00 PM, schrieb jsc@apache.org:
>> Author: jsc
>> Date: Tue Jun 19 10:00:15 2012
>> New Revision: 1351633
>>
>> URL: http://svn.apache.org/viewvc?rev=1351633&view=rev
>> Log:
>> 119977: update version number to 3.5
>>
>> Modified:
>>      incubator/ooo/trunk/main/instsetoo_native/util/openoffice.lst
>>      incubator/ooo/trunk/main/solenv/inc/version.lst
>>      incubator/ooo/trunk/main/sysui/desktop/productversion.mk
>>
>> Modified: incubator/ooo/trunk/main/instsetoo_native/util/openoffice.lst
>> URL:
>> http://svn.apache.org/viewvc/incubator/ooo/trunk/main/instsetoo_native/util/openoffice.lst?rev=1351633&r1=1351632&r2=1351633&view=diff
>>
>> ==============================================================================
>>
>> --- incubator/ooo/trunk/main/instsetoo_native/util/openoffice.lst
>> (original)
>> +++ incubator/ooo/trunk/main/instsetoo_native/util/openoffice.lst Tue
>> Jun 19 10:00:15 2012
>> @@ -4,15 +4,15 @@ Globals
>>       {
>>           variables
>>           {
>> -            SERVICETAG_PRODUCTNAME OpenOffice.org 3.4
>> -            SERVICETAG_PRODUCTVERSION 3.4
>> -            SERVICETAG_PARENTNAME OpenOffice.org 3.4
>> +            SERVICETAG_PRODUCTNAME OpenOffice.org 3.5
>> +            SERVICETAG_PRODUCTVERSION 3.5
>> +            SERVICETAG_PARENTNAME OpenOffice.org 3.5
>>               SERVICETAG_SOURCE {buildsource}{minor}(Build:{buildid})
>>               SERVICETAG_URN
>> urn:uuid:500061aa-5666-11e0-8e00-080020a9ed93
> 
> BTW:
> 
> IMHO another nice example to get rid of old and no longer needed code:
> The Service Tag [1] implementation from what has Sun included.
> 
> It's very simple:
> We don't want any registrations --> so we don't need Service Tags anymore.

good catch Marcus, we should check where this variable are used and
should clean up the code.

It can be a good opportunity work for somebody who want to do the first
steps with the code. OpenGrok to search where the variables are used +
understanding what's going on + some editing + building  + testing

Volunteers are welcome and questions will be answered here on the list
or on IRC

Juergen


> 
> [1]
> http://www.oracle.com/technetwork/articles/javase/productregistration-142210.html
> 
> 
> My 2 ct.
> 
> Marcus