From ooo-dev-return-21501-apmail-incubator-ooo-dev-archive=incubator.apache.org@incubator.apache.org Wed Jun 20 05:36:49 2012 Return-Path: X-Original-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-ooo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A622D91D7 for ; Wed, 20 Jun 2012 05:36:49 +0000 (UTC) Received: (qmail 33251 invoked by uid 500); 20 Jun 2012 05:36:48 -0000 Delivered-To: apmail-incubator-ooo-dev-archive@incubator.apache.org Received: (qmail 32789 invoked by uid 500); 20 Jun 2012 05:36:48 -0000 Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ooo-dev@incubator.apache.org Delivered-To: mailing list ooo-dev@incubator.apache.org Received: (qmail 32763 invoked by uid 99); 20 Jun 2012 05:36:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jun 2012 05:36:47 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of jogischmidt@googlemail.com designates 74.125.82.175 as permitted sender) Received: from [74.125.82.175] (HELO mail-we0-f175.google.com) (74.125.82.175) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jun 2012 05:36:39 +0000 Received: by werg55 with SMTP id g55so4772466wer.6 for ; Tue, 19 Jun 2012 22:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=CRgqM+k+K1HvSWkNBD2/G/WnHDMMU5So55QDOZ3lIpg=; b=yh6e/bfGihcIeCTrkCK1t9Fg4js0x8Imgy2sDDSSpOazMVRcQQuI3Fg76dl4bkkqpx vG1xk9LRZjiqUfbFbgljKCE0jpJYMrN9operoSjYCwQhqSX4vdiQVxFyMbRPsLJI3fso lftxOtRGzkS7wU8CbPu/fxp21495bBGKimy1163g8cCR7d/vNbQcqRbs3bgOpnpR9rSS 9MgGQ8U2y+LNfDShNSCgqpeZvNuW/u/jEnwwN6UalAwW0EDmmbbzUx+8PZKqXWx6g7p1 dxZjViGkbCwXxCxATYDzH+qWQSnZeFk9hNTwukg+sD24VGZ12LeJYxBS7F1dpF7k8A5o nc0g== Received: by 10.180.80.97 with SMTP id q1mr8927735wix.13.1340170579351; Tue, 19 Jun 2012 22:36:19 -0700 (PDT) Received: from [9.155.131.47] (deibp9eh1--blueice2n2.emea.ibm.com. [195.212.29.172]) by mx.google.com with ESMTPS id ei4sm69441009wid.5.2012.06.19.22.36.18 (version=SSLv3 cipher=OTHER); Tue, 19 Jun 2012 22:36:18 -0700 (PDT) Message-ID: <4FE16152.1070909@googlemail.com> Date: Wed, 20 Jun 2012 07:36:18 +0200 From: =?ISO-8859-1?Q?J=FCrgen_Schmidt?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:13.0) Gecko/20120601 Thunderbird/13.0 MIME-Version: 1.0 To: ooo-dev@incubator.apache.org Subject: Re: [RELEASE][3.4.1]: Include only one en-US dictionary extension References: <20120619030705.GC11324@localhost> <4FE02772.7090301@a-w-f.de> <4FE05D7A.5000409@googlemail.com> <298D04A1-882C-410E-B878-95BB2AC03274@comcast.net> <20120619141949.GA1786@localhost.sonyvaio> <8CA14C32-BE6B-43B7-8107-6BDBD860B2C1@comcast.net> In-Reply-To: <8CA14C32-BE6B-43B7-8107-6BDBD860B2C1@comcast.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 6/20/12 12:15 AM, Dave Fisher wrote: > > > Sent from my iPhone > > On Jun 19, 2012, at 9:19 AM, Ariel Constenla-Haile wrote: > >> On Tue, Jun 19, 2012 at 10:01:10AM -0400, Dave Fisher wrote: >>> But none of you are native English speakers. English varies from >>> country to country around the world. Why not disable or rename the >>> second version when the name collides? >> >> we cannot edit the extensions, they are downloaded and packaged "as is". >> On the other hand, the dict-en.oxt is a general dictionary extension, it >> supports the following locales: en-GB en-US en-ZA en-AU en-CA > > Would it be possible to reject extensions where the name collides inside of AOO? probably yes but a lot of work to workaround a bug in an extension. From my perspective not worth the effort at the moment. Config items can be overwritten by extension and the extension deployment mechanism have no clue for what the config items are used. > > Perhaps a description of why the extension manager chooses the bad NZ over the preferred and correctly named versions? Is the last or first with the name chosen? Would a known bad actor patch work? > without checking the details, I assume the last extension who write the config item wins. > The proposed solution effects many more users than are experiencing the problem. > I see no real problem here. > After all we are adding en-GB in this version. I am not sure if I understand you here. The dict-en.oxt included en-GB already, we include only the extension. Another solution would be to include a dictionary for en-US only in the en-US version, a en-GB only in the en-GB version and let all other en-* locales install via extensions later. But for this solution we would need clean dictionaries for en-US and en-GB only. Anyway cleaning up the current situation and including dict-en.oxt only is probably the best solution we can provide short term Juergen > > Regards, > Dave > > >> >> >> Regards >> -- >> Ariel Constenla-Haile >> La Plata, Argentina