incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From li zhang <lizh....@gmail.com>
Subject Re: [Call-for-​Review] one fix for odt saving performance improvement
Date Tue, 26 Jun 2012 05:33:25 GMT
hi, Juergen

thanks you for your interest in this topic and really appreciate your help.
On Fri, Jun 22, 2012 at 3:29 PM, Jürgen Schmidt
<jogischmidt@googlemail.com>wrote:

>  On 6/21/12 10:20 AM, Jürgen Schmidt wrote:
> > On 6/21/12 7:06 AM, li zhang wrote:
> >> for more information, you can refer to the below link:
> >>
> >>
> http://wiki.services.openoffice.org/wiki/ODT_saving_performance_improvement
> >>
> >> On Thu, Jun 21, 2012 at 1:00 PM, li zhang <lizh.fee@gmail.com> wrote:
> >>
> >>> hi, all
> >>> I'm zhang li from China. My main focus is performance(loading, saving,
> >>> asynchronous loading, etc).
> >>>
> >>> I have one fix need for review. It is about odt saving. Please check
> the
> >>> below for details, thanks!
> >>>
> >>> https://issues.apache.org/ooo/show_bug.cgi?id=120030
> >>>
> >>> root cause:
> >>> Do profiling on a sample file,
> SfxObjectShell::GenerateAndStoreThumbnail
> >>> is to be found occypy too much time, and it will call SwFlyFrm::Paint
> >>> several times, but it's unnecessary to paint thumbnail so many times
> when
> >>> saving.
> >>>
> >>> solution:
> >>> When thumbnail is generated and stored, in SwFlyFrm::Paint, current
> >>> visible rectangle will be compared with fly frame rectangle, if the two
> >>> rectangles don't intersect, SwFlyFrm::Paint will return, need no
> repaint.
> >>>
> >>
> >
> > I will take care of this
>
> I had some problems with building on trunk in general. Nothing that
> depends on your patch but it takes more time to built and test the patch.
>
> Juergen
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message