incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From li zhang <lizh....@gmail.com>
Subject Re: [Call-for-​Review] one fix for odt saving performance improvement
Date Tue, 26 Jun 2012 05:40:46 GMT
hi Pitonyak

Thank you for your attention to this topic. I will test the sample file
mentioned in your mail and update the result.
On Fri, Jun 22, 2012 at 2:45 PM, Andrew Douglas Pitonyak <
andrew@pitonyak.org> wrote:

>  On 06/21/2012 01:00 AM, li zhang wrote:
>
>> hi, all
>> I'm zhang li from China. My main focus is performance(loading, saving,
>> asynchronous loading, etc).
>>
>> I have one fix need for review. It is about odt saving. Please check the
>> below for details, thanks!
>>
>> https://issues.apache.org/ooo/**show_bug.cgi?id=120030<https://issues.apache.org/ooo/show_bug.cgi?id=120030>
>>
>> root cause:
>> Do profiling on a sample file, SfxObjectShell::**GenerateAndStoreThumbnail
>> is
>> to be found occypy too much time, and it will call SwFlyFrm::Paint several
>> times, but it's unnecessary to paint thumbnail so many times when saving.
>>
>> solution:
>> When thumbnail is generated and stored, in SwFlyFrm::Paint, current
>> visible
>> rectangle will be compared with fly frame rectangle, if the two rectangles
>> don't intersect, SwFlyFrm::Paint will return, need no repaint.
>>
>> Excellent.... I hope this speeds up the save time on
>
> http://www.pitonyak.org/OOME_**3_0.odt<http://www.pitonyak.org/OOME_3_0.odt>
>
> Document loads pretty fast, but saving is horrid!
>
> Do you have a link for more information related to "how to profile OOo"?
>
> --
> Andrew Pitonyak
> My Macro Document: http://www.pitonyak.org/**AndrewMacro.odt<http://www.pitonyak.org/AndrewMacro.odt>
> Info:  http://www.pitonyak.org/oo.php
>
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message