incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fan Zheng <zheng.easy...@gmail.com>
Subject Re: [Call For Review] Bugzilla 119963
Date Thu, 28 Jun 2012 05:47:43 GMT
Not the updated patch is already uploaded into bugzilla. For you review.
thanks.

2012/6/28 Fan Zheng <zheng.easyfan@gmail.com>

> Hi, See my answer below in blue
>
> 2012/6/27 Oliver-Rainer Wittmann <orwittmann@googlemail.com>
>
>> Hi,
>>
>>
>> On 14.06.2012 14:11, Oliver-Rainer Wittmann wrote:
>>
>>> Hi,
>>>
>>> On 14.06.2012 13:58, chengjh wrote:
>>>
>>>> This is the I implementation of  the proposal described in thread
>>>> "Propose
>>>> to Implement the Loading of TOC and Improve TOC Fidelity with MS Word
>>>> Binary Document"..review comments expected...
>>>>
>>>> On Thu, Jun 14, 2012 at 3:31 PM, Fan Zheng<zheng.easyfan@gmail.com>
>>>>  wrote:
>>>>
>>>>  Hi, all:
>>>>>
>>>>> This is ZhengFan. I have finished the bug fix/feature implementation
of
>>>>> bugzilla 119963. Now the patch was attached for review. Thanks a lot!
>>>>>
>>>>> Here is the link:
>>>>>
>>>>> https://issues.apache.org/ooo/**show_bug.cgi?id=119963<https://issues.apache.org/ooo/show_bug.cgi?id=119963>
>>>>>
>>>>>
>>>>
>>> I am volunteering to review the patch.
>>>
>>>
>> Here is my first minor feedback on the patch:
>> The changes to /sw/inc/tox.hxx and the call of method <SwTOXBase::**SetMSTOCExpression(..)>
>> in /sw/source/filter/ww8/ww8par5.**cxx are not needed for enhancement
>> 119963 from my point of view. Right?
>> For me it looks like that these changes are already for the next
>> improvement step - exporting imported Microsoft Word TOC. Right?
>>
> Oliver, you are so right. Yes, such maMSTOCExpression corresponding stuff
> is not necessarily the case, and yes, those things are prepared fo
> exporting job of TOC in next step. I will remove them ASAP.
>
>
>> If yes, I would propose to remove this change for now.
>>
>> Back to the code for further review.
>>
>> Best regards, Oliver.
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message