incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pengyunquan <pengyunq...@gmail.com>
Subject [Call for review]Bug 119994 - [From Symphony]Cannot modify the second document even if close range picker in first document
Date Fri, 15 Jun 2012 03:43:36 GMT
Hi, all

I have a fix for bug
119994<https://issues.apache.org/ooo/show_bug.cgi?id=119994>

https://issues.apache.org/ooo/show_bug.cgi?id=119994

Can anyone help me to review the fix?

    Root Cause : On creation of SD, the Range picker dialog of the SC
document is hidden, and it is in nonmodal state. When the new dialog
for creation of SD is popped up, in its call of
Dialog::SetModalInputMode, it changes its previous execute dialog( the
Range picker dialog for SC ) to modal state without check whether the
excuting dialog is in modal state. In the case of this bug, the Range
picker dialog should not be changed to modal state becaused its range
picker is running, and its user event should be handled by the SC
document. If the Range picker dialog is incorrectly changed to modal
state, it handle the user event and it is hidden, so the document can
not respond to the user's mouse click on document, and the document is
lock.

    Solution : In Dialog::SetModalInputMode, if prev-execute dialog is
not in modal state, skip prev-execute dialog, and check the
prev-prev-dialog, untill find a modal dialog.



Thanks,

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message