incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tanli li <litan.t...@gmail.com>
Subject [Call-for-​​​Review][​Calc] Bug 119989: Pie chart height becomes greater when open Excel file
Date Thu, 14 Jun 2012 15:30:35 GMT
Hi All,
      I write to request review of  a fix patch as following link
https://issues.apache.org/ooo/show_bug.cgi?id=119989

Defect: Pie chart height in AOO is higher than MS Excel

Root Cause:
When import .xls files, AOO3.4 don't read 3D height of Piechart in files
and let it show a fixed value of height.

Solution:
Set the piechart 3D height according to XclImpChChart3d record in imported
xls file. Correspondingly, add 3D height property names in xlchart.hxx
and set it to ScfPropertySet in xichart.cxx. When create 3D piechart, we
will get its 3D height from model and set height fDepth in
PieChart::createShapes().
In chart model, we also add default value of 3D height property as usual.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message