incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oliver-Rainer Wittmann <orwittm...@googlemail.com>
Subject Re: Propose for 3.4.1: Can't remove password from file (119366)
Date Mon, 25 Jun 2012 11:11:04 GMT
Hi,

On 25.06.2012 10:20, Fan Zheng wrote:
> Hi, All:
>
> This issue was solved, now call for the reviewers.
>
> In general, this is a setting confusion issue. In current saving process,
> both SID_ENCRYPTIONDATA and SID_PASSWORD are working for setting password
> on a document.
> Refer to the SfxObjectShell::ExecFile_Impl() in file
> SRC/sfx2/source/doc/objserv.cxx:line 595-599 please.
> And, as what we imagine, after doing the file dialog executing with
> deselecting the check box of "Save with password", the result parameter
> set, which is to customize saving process, wont record said 2 SID inside
> anymore, for indicating that the following saving process will not concern
> about the password stuff anymore.
> But when performing the exact preparation SaveAs process in
> SfxobjectShell::PreDoSaveAs_impl(), only the the default SID_PASSWORD was
> cleared, but  SID_ENCRYPTIONDATA  was not. The issue happens.
>
> For solving it, we just simply add the item SID_ENCRYPTIONDATA  clearing
> in  SfxobjectShell::PreDoSaveAs_impl(), similar as the SID_PASSWORD.
>

I have reviewed the patch.
Please see my comments in the issue [1] and [2]

[1] https://issues.apache.org/ooo/show_bug.cgi?id=119366#c9
[2] https://issues.apache.org/ooo/show_bug.cgi?id=119366#c11


Best regards, Oliver.

Mime
View raw message