incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andre Fischer ...@a-w-f.de>
Subject Re: [Call-for-​​Review][C​alc]The .xlsx sample file is opened with modified state
Date Wed, 13 Jun 2012 13:12:12 GMT
Done.

Thanks for the good work.

-Andre

On 13.06.2012 14:39, Andre Fischer wrote:
> I will take care of this one.
>
> -Andre
>
> On 13.06.2012 08:49, Clarence GUO wrote:
>> Hi~
>> I'm Clarence, a developer from Symphony project. My area is chart2,
>> and sc,
>> sd, svx, sfx2, vcl...
>>
>> I uploaded a patch for review.
>> https://issues.apache.org/ooo/show_bug.cgi?id=119492
>>
>> Open the .xlsx sample file attached.
>> Check the state of the Save button on toolbar. It will be enabled.
>> Close the file without any change, a dialog will popup to ask whether you
>> want to save the change.
>>
>> Root Cause:
>> chart was set modify flag to true during loading.
>>
>> Solution:
>> Reset all OLE's modify flag to false at the end of ImportFrom. It's the
>> major filer method of MSOffice2010. As SD has the same problem(SW doesn't
>> support import chart of MSOffice2010 yet), ImportFrom is the joint
>> entry of
>> the three applications, and MS2003 and ODF have no such problem, so it
>> should the correct place to reset the flag.
>>
>


Mime
View raw message