incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jürgen Schmidt <jogischm...@googlemail.com>
Subject Re: [Call-for-Review] Fix for bug 119912 (Crash when redo split the pasted table)
Date Fri, 08 Jun 2012 09:35:20 GMT
On 6/8/12 11:07 AM, Peng Chen wrote:
> Jurgen, thank you for review and check in.

well the patch doesn't compile out of the box.

bSeqDispose is not declared in the scope, I assume you missed something
in the patch.

I did a quick test by declaring it in the loop and it worked but I
assume you declare it in the header (unochart.hxx)

Let me know

Juergen

> 
> 2012/6/8 Jürgen Schmidt <jogischmidt@googlemail.com>
> 
>> On 6/8/12 10:33 AM, Peng Chen wrote:
>>> Hi, all
>>>
>>> I had a fix for bug 119912
>>>
>>> https://issues.apache.org/ooo/show_bug.cgi?id=119912 ,
>>> it is about application crash when undo & redo a split pasted table.
>>>
>>> Can anyone help to review the fix?
>>> Thank you!
>>>
>> done
>>
>> reviewed, built and tested -< patch applied on trunk, no crash anymore
>>
>> Thanks
>>
>> Juergen
>>
> 


Mime
View raw message