Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ooo-dev@incubator.apache.org
Date: Mon, 16 Apr 2012 07:06:56 -0300
From: Ariel Constenla-Haile <arielch@apache.org>
To: ooo-dev@incubator.apache.org
Subject: Re: Cannot select a different icon set
Message-ID: <20120416100656.GB17087@localhost>
References: <4F8369D1.3040003@apache.org>
 <20120415183301.GA26110@localhost>
 <4F8B441E.3000108@apache.org>
 <20120416020633.GB22611@localhost>
 <4F8B8842.5000006@apache.org>
 <20120416040855.GC31544@localhost>
 <4F8BAB95.7090606@apache.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="z6Eq5LdranGa6ru8"
Content-Disposition: inline
In-Reply-To: <4F8BAB95.7090606@apache.org>
User-Agent: Mutt/1.5.21 (2010-09-15)

--z6Eq5LdranGa6ru8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Pedro,

On Mon, Apr 16, 2012 at 12:18:13AM -0500, Pedro Giffuni wrote:
> >IMHO we shouldn't remove anything, on the contrary we should revert all
> >changes: the list of icon styles is filled in the constructor of
> >OfaViewTabPage. Ultimately, the existence of an icon set is checked on
> >bool ImplImageTree::checkStyle(rtl::OUString const&  style) so that
> >non-existent icon styles are removed from the list box.
> >
> >IMO we should keep all the list as it was before, with all icon styles,
> >so that the user can install by herself/himself the ones AOO can't ship
> >due to license issues.
> >
> >This means reverting changes in
> >::rtl::OUString StyleSettings::ImplSymbolsStyleToName( sal_uLong nStyle =
) const
> >sal_uLong StyleSettings::ImplNameToSymbolsStyle( const ::rtl::OUString&r=
Name ) const
> >sal_uLong StyleSettings::GetAutoSymbolsStyle() const
> >
> >and some other places.
>=20
> That is not a bad idea, but still that would mean changing again the menus
> to bring back the Crystal icons, which would not be there by default.=20

Bringing back the string item list as it was before, will imply
translation work, so it must be done on trunk after AOO340 is branched.

> At the very least the crystal and Tango icons should be left towards
> the end of the list and not in the middle as they were originally.

Why? The order on the list box has to do with the constants order. If
the icon set is not present, the corresponding list box item is removed
at runtime,  in the constructor of OfaViewTabPage.


Regards
--=20
Ariel Constenla-Haile
La Plata, Argentina

--z6Eq5LdranGa6ru8
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJPi+9AAAoJEMjP1bm45QNWbowP/1HcYnrzIZTGPl7c3YopG2ef
LEYTECiUEc/h6ofIdghoBggI30ejFXO3Y+g72+sDjjD+vMVsNuw3PB6Zb3jT8/tL
+N4Ydzruis20bp1abwUe40blVPkeusEovOGuNsw2O3RpyP9Os1ER4AhHTOOVBfMP
gcj/iZoF0X+wibr+HpPQtPBENt4RPDStjmE1YGrEeewJ3egsxZc7v1NV8MVgGEKd
ZIe0FOStYwFjlVpz2M9xGzk0R2Hiv5OhomrIo2iOdYKyUcktpUsvnXp7bdiP0JR1
3r+Q70vcGuSx4a8iTTyVGFTc0D7fe8b3ykqxFPVZojls8bWIXrlQE/UJ4mWsTwww
i9a5En129xjpEgV+48GUpaW6khHlwoLJgA9+fu1JxEOBFX+acvaR6XduZTc9PQo6
cHsdsDccT5daLqCwPbHyFtaz2VkN+CgOya6hGdPjPhFVeHempO7KTg+h5tqV8Uso
x0898d2rlVBovA/jWqLX1u286la7GRT2T1DmJ39WqQXpKH517qox13xiaog9aGsx
26sg+nOGX0J7J9i30Yul9ZHTQrvq8iTbO4eY674UJHKefj0dvttk6Fjvm88WvW3C
9NjiLSCETXT1JtTN/ta17ABnaprZ0DED3quo4xG62ADH+oIg+Xl3satGAiayLrvo
4MU9aaxp0aGaDmWPzADb
=4FJk
-----END PGP SIGNATURE-----

--z6Eq5LdranGa6ru8--