incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ariel Constenla-Haile <arie...@apache.org>
Subject Re: [RELEASE] Dictionary extensions
Date Sun, 15 Apr 2012 11:11:54 GMT
Hi Andrea,

On Sun, Apr 15, 2012 at 7:29 AM, Andrea Pescetti <pescetti@apache.org> wrote:
> Andrea Pescetti wrote:
>>
>> To address Ariel's concerns: this is independent of the
>> file name, since the Extensions website stores new revisions in
>> different directories (just look at the diff above; it should be clear).
>
>
> No, actually something is wrong here. I assumed that the script would
> download the file again if the checksum did not match the one listed in
> extensions.lst (which seems the reasonable behavior to me).
>
> But this didn't happen for the Italian dictionary in r1325589, just checked.
> So indeed, as Ariel says, we have two possible workarounds (clear the local
> mirror of extensions before build; rename extensions to be downloaded) but
> the solution would be to enforce that the MD5 matches the expected one from
> extensions.lst and, if it doesn't, to download the extension again.

checking the MD5 sounds better.
The attached patch seems to fix the issue (it updated 8 extensions on
the first run, none on the second).

Regards

Mime
  • Unnamed multipart/mixed (inline, None, 0 bytes)
View raw message