Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ooo-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of dennis.hamilton@acm.org
 designates 216.119.133.2 as permitted sender)
Reply-To: <dennis.hamilton@acm.org>
From: "Dennis E. Hamilton" <dennis.hamilton@acm.org>
To: <ooo-dev@incubator.apache.org>
References: <4F5201D3.9060905@apache.org>
	<1330784491.35146.YahooMailClassic@web113520.mail.gq1.yahoo.com>
	<CAP-ksohZnLNM-QyLcsNJ2KBZ+aJWwxYh6+7iHqOUeydPirvEsg@mail.gmail.com>
	<4F52529D.80701@apache.org>
	<CAP-ksohxZ4qRd_g+0BVKQmjS0V2p7iWr=AHPdnA_rwq-iq7Q8A@mail.gmail.com>
	<00bd01ccf975$2b1ccf60$81566e20$@acm.org>
 <CAP-ksohM7NZkfVyYfFH+OzUvmMFAWdjtg5NHRTvkCniFm-z5kw@mail.gmail.com>
In-Reply-To: 
 <CAP-ksohM7NZkfVyYfFH+OzUvmMFAWdjtg5NHRTvkCniFm-z5kw@mail.gmail.com>
Subject: RE: Nominate release blocker: 118999 - Leap year not correctly
 calculated
Date: Sat, 3 Mar 2012 14:34:52 -0800
Organization: NuovoDoc
Message-ID: <00e701ccf98d$da48a280$8ed9e780$@acm.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: en-us
Thread-Index: 
 AQG+ozERaPFcTVGPSyXQOd0SZUmv9wItc/ySAYhhBWYBW3W6hAFycNURAY7L/wIC9mY7W5YdjAYQ

Amen on understanding the scope of the bug!!

As promised, I built a smoke-test document and ran it.  The bug does not =
appear at all in any Windows version of OpenOffice.org that I tested.  =
In particular, it does not appear in OpenOffice.org 3.3.0, in the Oracle =
OOo-dev 3.4.0 developer release, nor in the Apache OpenOffice OOo-dev =
3.4 Developer Snapshot r1293550.

For more grounding, I confirmed that the bug also is missing from =
LibreOffice 3.3.2, the one I use for production, but it does appear in =
LibreOffice 3.5.0.=20

So, whatever the origin of the defect, it apparently does not exist in =
the Apache OpenOffice lineage from OpenOffice.org.

On the other hand, it would be good to keep the smoketest document =
around, just in case.

The file and screen captures demonstrating the presence and absence of =
smoke are all attacked to the AOO Bugzilla report #118999.

-----Original Message-----
From: Rob Weir [mailto:robweir@apache.org]=20
Sent: Saturday, March 03, 2012 14:12
To: ooo-dev@incubator.apache.org
Subject: Re: Nominate release blocker: 118999 - Leap year not correctly =
calculated

On Sat, Mar 3, 2012 at 2:38 PM, Dennis E. Hamilton
<dennis.hamilton@acm.org> wrote:
> The reported bug is about a date conversion error on loading of a =
stored ODP file.  It appears from the description that the conversion =
fails and a serial-date number of 0 results.
>
> If it can be confirmed that the error is localized to that case, the =
fix has to be benign.  This would be unrelated to whether or not there =
are other defects involving serial-date numbers that correspond to the =
leap days on any calendar.
>

I was hoping that OO did not have several independent places where
leap year logic was coded, some with bugs, some without.  But if it
the case that this bug is only in the data input and conversion logic
and not in the calculation logic, then great.   But I think that would
need to come from analysis of the code dependencies, not analysis of
the defect report.

Hopefully we agree that understanding the scope of the bug is a real
good thing here,

-Rob