incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armin Le Grand <Armin.Le.Gr...@me.com>
Subject Re: Hanging implementation of secant functions
Date Fri, 17 Feb 2012 10:12:18 GMT
	Hi Regina,

same procedure as for the chart features, please :-) Sorry for the 
hassle and thanks in advance! I'll also take a look at the used IDs and 
if they are free or not...

Sincerely,
	Armin

On 16.02.2012 22:38, Regina Henschel wrote:
> Hi Armin,
>
> Armin Le Grand schrieb:
>> Hi Regina,
>>
>> On 15.02.2012 14:30, Regina Henschel wrote:
>>> Hi all,
>>>
>>> with https://issues.apache.org/ooo/show_bug.cgi?id=117312 and
>>> https://issues.apache.org/ooo/show_bug.cgi?id=111413 the implementation
>>> of the functions SEC, CSC, SECH and CSCH was planed. Patch is attached
>>> there. Because of the transition it hangs now. How to proceed?
>>
>> To avoid misinterpretations: Is this fully implemented and checked or
>> work in progress? Can it be comitted 'as-is'?
>
> It is implemented in LibreOffice in 3.4.5 and 3.5. Eike has made the
> following changes:
> In file formula/inc/formula/compiler.hrc he uses the numbers 98, 99,
> 100, 101 and shifts the following numbers accordingly, where I had used
> the numbers 395, 396, 397, 398.
> The file scfuncs.hrc is not used in LO and can not be used in AOO too,
> because the way helpids are handled has changed in the meantime.
> Therefore Eike has made the necessary changes in file /sc/inc/helpids.h
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=9dd0e2aabcddcac3dc961933b7bed8d612a43e58
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=1e3e411b54b2d556ee1df8b903d8ff311419dc99
>
> (You find the relevant commits there with search for SECH in log msg)
>
> The other changes in LO are the same as in my patches, which are
> attached to the issue.
>
> So how to proceed? Copy the changes of file "helpids.h"? Change the
> numbers or stick with my numbers? Generate a new patch?
>
> Kind regards
> Regina
>
>
>

--
ALG


Mime
View raw message