Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ooo-dev@incubator.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <1327034526.2192.YahooMailClassic@web113506.mail.gq1.yahoo.com>
Date: Thu, 19 Jan 2012 20:42:06 -0800 (PST)
From: Pedro Giffuni <pfg@apache.org>
Reply-To: pfg@apache.org
Subject: Re: Next step: fonts
To: ooo-dev@incubator.apache.org
In-Reply-To: <20120120035427.GB10282@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Looks good (and youre fast!)

I am not sure why you need to add stuff in configure
instead of reusing ENABLE_GRAPHITE in the .scp file
Too, but perhaps its too late here and I am tired ;).

Add a couple of lines to the NOTICE file (and fix
my typo if you like) and its done.

Thanks, this is pretty cool!

Pedro.

--- Gio 19/1/12, Ariel Constenla-Haile <arielch@apache.org> ha scritto:
...
> -0800, Pedro Giffuni wrote:
> > Hmm ...
> >=20
> > --- Gio 19/1/12, Ariel Constenla-Haile <arielch@apache.org>
> ha scritto:
> > ...
> > >=20
> > > I don't get the "force people" as long as we
> already have
> > > configure switches that set ENABLE_GRAPHITE and
> WITH_FONTS
> > >=20
> >=20
> > Yes but people should be warned and taking out all the
> > fonts unless you enable graphite would be drastic.
> >=20
> > I guess we could condition the specific liberation
> > font by adding || graphite checks in
> >=20
> > main/scp2/source/ooo/file_font_ooo.scp
> > and
> > main/more_fonts/fonts/ttf_libertine/makefile.mk
>=20
>=20
> I guess this should be down following the WITHOUT_FONTS
> define done in
> configure.in, see attached patch.
>=20
>=20
> Regards
> --=20
> Ariel Constenla-Haile
> La Plata, Argentina
>