incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armin Le Grand <Armin.Le.Gr...@me.com>
Subject Re: New feature: Drawing thick lines with line caps
Date Wed, 18 Jan 2012 09:06:31 GMT
	Hi Pavel,

On 17.01.2012 21:29, Pavel Janík wrote:
> Armin,
>
> On Jan 17, 2012, at 6:56 PM, Armin Le Grand wrote:
>
>> I have reintegrated the finished feature from the branch to trunk. Kudos go to Regina
for the basic implementation and for offering it here.
>
> can you please have a look at the code? This NOT-TO-BE-INTEGRATED change shows the WaE
issue in vcl:

Thanks, added mac code as needed (wondering why the mac build I made 
yesterday worked well and showed linecaps as intended)...

> --- vcl.orig/aqua/source/gdi/salgdi.cxx	2012-01-17 19:51:19.000000000 +0100
> +++ vcl/aqua/source/gdi/salgdi.cxx	2012-01-17 19:52:07.000000000 +0100
> @@ -987,6 +987,7 @@
>   	basegfx::B2DLineJoin eLineJoin,
>       com::sun::star::drawing::LineCap eLineCap)
>   {
> +  (void)eLineCap; // Unused parameter...
>   	// short circuit if there is nothing to do
>   	const int nPointCount = rPolyLine.count();
>   	if( nPointCount<= 0 )
>
> And this one should be integrated:

Changed, done. Thanks!

> --- svx.orig/source/xoutdev/xattr2.cxx	2012-01-17 21:21:03.000000000 +0100
> +++ svx/source/xoutdev/xattr2.cxx	2012-01-17 21:28:40.000000000 +0100
> @@ -451,7 +451,7 @@
>           || com::sun::star::drawing::LineCap_ROUND == eRetval
>           || com::sun::star::drawing::LineCap_SQUARE == eRetval, "Unknown enum value
in XATTR_LINECAP (!)");
>
> -    return (com::sun::star::drawing::LineCap)SfxEnumItem::GetValue();
> +    return eRetval;
>   }
>
>   //------------------------------
>

Sincerely,
	Armin
--
ALG


Mime
View raw message