incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus (OOo)" <marcus.m...@wtnet.de>
Subject Re: [CODE] Replace buildid by svn revision, and fix broken --with-build-version
Date Tue, 27 Dec 2011 23:32:11 GMT
Am 12/21/2011 01:50 AM, schrieb Marcus (OOo):
> Of course a build number is very useful to identify builds which look
> equal at first view (e.g., same version number, same release date,
> whatever). And I like the short one that we have used for years.
>
> However, I also know that it is nowadays common just to use the revision
> number from the used code repository.
>
> So, if we all agree to use this instead of the old build numbers, then I
> would suggest to add "svn" to the string to make it clear where the
> number comes from:
>
> (Build:svn-1234567890)
>
> or more patch-like (yes, I know it's far away from been correct ;-) ):
>
> -RSCREVISION=340m1(Build:$(BUILD_REVISION))
> +RSCREVISION=340m1(Build:svn-$(BUILD_REVISION))
>
> Furthermore, it's great to have a detailed timestamp in the About
> dialog. That will simplify the work of QA and support to identify which
> version exactly the users have problems with.
>
> So, thanks Ariel for your initiative to drive this change.
>
> Marcus

As I haven't seen any other comments to this, are you planning to commit 
the changes in this way or have you got other thoughts in the meantime?

Thanks

Marcus



> Am 12/20/2011 10:20 PM, schrieb Ariel Constenla-Haile:
>> Hi there,
>>
>> the attached patches are an attempt to replace the build-id by the
>> subversion revision; and fix --with-build-version that didn't work.
>>
>> The svn revision is set in configure (I guess this could have been done
>> somewhere in the perl installer code).
>> It supports both subversion and git-svn repositories. In case of plane
>> sources without repo, the build-id is set to 0.
>> (Tested only with git-svn).
>>
>> With the following configure switches
>>
>> ./configure \
>> --with-build-version="$(date +"%Y-%m-%d %H:%M:%S %z (%a, %d %b %Y)")" \
>> --enable-verbose \
>> --enable-category-b \
>> ...
>>
>> the About Dialog looks like:
>>
>> http://people.apache.org/~arielch/images/AboutDlg.png
>>
>> You can try with this Win build:
>>
>> http://people.apache.org/~arielch/packages/OOo-Dev_OOO340m1_Win_x86_install-arc_en-US.zip
>>
>> On WinXP the BUILD_VER_STRING looks too small, may be the font size
>> should be increased.
>>
>> Tests and comments/improvements are welcome :)
>>
>>
>> Regards

Mime
View raw message