incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ariel Constenla-Haile <arie...@apache.org>
Subject Re: svn commit: r1225428 - /incubator/ooo/trunk/main/sc/source/ui/unoobj/cellsuno.cxx
Date Fri, 30 Dec 2011 16:53:23 GMT
Hi Pavel,

On Fri, Dec 30, 2011 at 05:36:31PM +0100, Pavel Janík wrote:
> 
> On Dec 29, 2011, at 5:34 AM, arielch@apache.org wrote:
> 
> > Author: arielch
> > Date: Thu Dec 29 04:34:21 2011
> > New Revision: 1225428
> > 
> > URL: http://svn.apache.org/viewvc?rev=1225428&view=rev
> > Log:
> > i118696 - i118697 - Fix some Sheet Tab Color API issues
> > 
> > Modified:
> >    incubator/ooo/trunk/main/sc/source/ui/unoobj/cellsuno.cxx
> > 
> > Modified: incubator/ooo/trunk/main/sc/source/ui/unoobj/cellsuno.cxx
> > URL: http://svn.apache.org/viewvc/incubator/ooo/trunk/main/sc/source/ui/unoobj/cellsuno.cxx?rev=1225428&r1=1225427&r2=1225428&view=diff
> > ==============================================================================
> > --- incubator/ooo/trunk/main/sc/source/ui/unoobj/cellsuno.cxx (original)
> > +++ incubator/ooo/trunk/main/sc/source/ui/unoobj/cellsuno.cxx Thu Dec 29 04:34:21
2011
> > @@ -8543,11 +8543,12 @@ void ScTableSheetObj::SetOnePropertyValu
> >         }
> >         else if ( pEntry->nWID == SC_WID_UNO_TABCOLOR )
> >         {
> > -            sal_Int32 nColor = COL_AUTO;

I have no idea why I changed that line...

> > -            if (aValue >>= nColor)
> > +            sal_Int32 nColor;
> > +            if ( aValue >>= nColor )
> 
> this changes is not WaE free on some compilers:
> 
> sc/source/ui/unoobj/cellsuno.cxx:8546: warning: ‘nColor’ may be used uninitialized
in this function
 

thanks for pointing this out.


Regards
-- 
Ariel Constenla-Haile
La Plata, Argentina

Mime
View raw message