Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ooo-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of orwittmann@googlemail.com
 designates 209.85.161.47 as permitted sender)
Message-ID: <4EB7A481.6080509@googlemail.com>
Date: Mon, 07 Nov 2011 10:27:29 +0100
From: Oliver-Rainer Wittmann <orwittmann@googlemail.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1
MIME-Version: 1.0
To: ooo-dev@incubator.apache.org
Subject: Re: [CODE] issue 118576: Crash on close
References: <DBC4BC7B-246A-4C53-9813-1EB683D60DAA@free.fr>
 <4EB79C14.6090307@a-w-f.de>
In-Reply-To: <4EB79C14.6090307@a-w-f.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

I am supporting Andre's proposal to revert the config manager singleton 
fix and postpone it and the fixes regarding the unregistered config 
items to a time, when we have finished the "IP cleared" milestone.

Best regards, Oliver.

On 07.11.2011 09:51, Andre Fischer wrote:
> Hi,
>
> I have news on this, but not good news.
>
> The crash is not directly caused but triggered by the fix for issue
> 112786. That issue fixes the config manager singleton to actually
> getting destroyed when the office closes. Not destroying it is not nice
> but, to my knowledge, causes not observable problems.
>
> Now that the config manager is destroyed, it checks whether there are
> still any registered config items. There should be none at this point
> but in reality there is one when no application is started and about six
> when for example the writer is started and closed immediately.
>
> Not wanting to leave anything behind the config manager destroys the
> lingering config items. Because the office is already half down and the
> infrastructure for destroying the config items is not in place anymore,
> that causes the crash.
>
> So, every remaining config item causes its own separate crash. Each has
> to be fixed on its own. Some even cause secondary crashes when a config
> items in its destructor tries to destroy the resources it still holds.
>
> The root cause here is that the config items are registered but are not
> unregistered. Fixing this issue means finding the owner of the offending
> config item and make it properly unregister and destroy the item.
>
> Fixing this is a time consuming process. I have one item fixed (see the
> patch for issue 118576) and a second one in the making. That means that
> four are still open. As there are more important things to do right now,
> like getting the conflicting IP stuff removed, I suggest to remove the
> patch of issue 112786 and fix this properly at a later point in time.
>
> Regards,
> Andre
>
> On 06.11.2011 09:50, eric b wrote:
>> Hi Andre,
>>
>> I confirm the crash on windows when quit, and I can try to have a look
>> at your code, compile it and review it on Windows.
>>
>>
>> Regards,
>> Eric
>>
>>
>> P.S. : I created a new thread, because I just subscribed again to the
>> list, to fix the issue with you on list (because of the flow, I prefer
>> use to follow the list using
>> http://mail-archives.apache.org/mod_mbox/incubator-ooo-dev/ )
>>