Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ooo-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of ariel.constenla.haile@gmail.com
 designates 209.85.161.175 as permitted sender)
Date: Tue, 8 Nov 2011 18:50:45 -0300
From: Ariel Constenla-Haile <ariel.constenla.haile@gmail.com>
To: ooo-dev@incubator.apache.org
Subject: Re: Issuew building with prepackaged stuff (was Re: Problem building
 main/sal/cppunittester)
Message-ID: <20111108215045.GC25920@localhost>
References: <20111108203700.GB25920@localhost>
 <1320787269.30058.YahooMailClassic@web113509.mail.gq1.yahoo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="6zdv2QT/q3FMhpsV"
Content-Disposition: inline
In-Reply-To: <1320787269.30058.YahooMailClassic@web113509.mail.gq1.yahoo.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

--6zdv2QT/q3FMhpsV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Pedro,

On Tue, Nov 08, 2011 at 01:21:09PM -0800, Pedro Giffuni wrote:
> > looking at https://issues.apache.org/ooo/show_bug.cgi?id=3D118574=20
> > IMHO the solution is not acceptable: you cannot include a
> > header that is not used at all in that file.
> > None of the files you've patched so far
> > uses wchar.h directly, so the issue is with the BSD port
> > and should be fixed there.
> >=20
>=20
> I agree that this issue seems to be particular of the
> FreeBSD port.
> I discussed this with Maho@ a while ago and we decided we
> will keep the patch in our local port.
>=20
> > Notice that your issue is because your using your system's
> > libxml2:
> >=20
> > libxml/encoding.h includes /usr/local/include/iconv.h if
> > LIBXML_ICONV_ENABLED is defined. So you see that error on
> > every OOo file
> > that includes a libxml header that in turn includes
> > libxml/encoding.h
> >=20
> > On Fedora, building with system libxml works fine, I don't
> > get that
> > error. In fact, /usr/local/include/iconv.h has no line 114
> > and it does
> > not use mbstate_t at all.
> > I wonder how your system's iconv.h looks like, does it use
> > mbstate_t at
> > all? Is your system's libxml configured with
> > LIBXML_ICONV_ENABLED?
> >
>=20
> I am using libiconv-1.13.1 and libxml2-2.7.8.
> libxml is configured to use libiconv.
>=20
> It sure uses mbstate_t:
>=20
> /usr/local/include/iconv.h
>=20
> ...
> /* A type that holds all memory needed by a conversion descriptor.
>    A pointer to such an object can be used as an iconv_t. */
> typedef struct {
>   void* dummy1[28];
> #if 1
>   mbstate_t dummy2;
> #endif
> } iconv_allocation_t;
> ...
>=20
> This doesn't seem to be BSD specific though, shouldn't
> everyone be using libiconv with libxml2 ?

on Fedora, iconv comes built-in with glibc:

~]$ sudo yum whatprovides /usr/include/iconv.h

glibc-headers-2.14-5.x86_64 : Header files for development usin standard C =
libraries.
Repo        : installed
Matched from:
Other       : Provides-match: /usr/include/iconv.h

* there is no standalone libiconv
* iconv.h is only 56 lines long, and does not use mbstate_t at all
  http://bit.ly/uLImuD

So this is a BSD issue.

Regards
--=20
Ariel Constenla-Haile
La Plata, Argentina

--6zdv2QT/q3FMhpsV
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJOuaQ1AAoJEMjP1bm45QNWYB0P/iwGN09NofJs0/B7upUSdnsm
MwchXe2+zXnmxsbp2KHTa5aIJsf2i9Z4mEDdrICWt1CCEUqU2w+9MZj8RK7p6Tcj
Z15KEVqsK1xHPp7TlI+5n/cZduDIE4mv+z2TjCcb434wpJvPkfElmpwvn9R2CVoE
UPSV05yg4cNGRmVoIaqHaBqO+UdWdRoSgNYZzX1WSmmTe3QapygmRWD/L4beSNZc
ST9d6p/OXJw5axQEb+Ae+ziw8gLAbvAcfi18TPk+eOgPFpoYwqId2v0HgYe/VsWQ
AjhqTvTYIRvrKKZwRsIQhMDw4g5FDlbde9R58tJDavI0ujXH3dTeHWQXo1bpiYtR
UCR5iC04siwKRZmkdnhVaiAjspbXpjYo2UvGHmWaAy8NFZGFAdYnRyay94A5F74C
rhsy3DFc8I/nKjywODfQefSd1iGkTHfuBZBDNvHAn8T1NwnjfYj4SJ1TyzrpsZ4S
W/5yQjwbInlAWzFpTwaKmnutkfh9N1Hm4AD5DoD1CmPNqsW/sMEC6fiuCP2eevZE
CshZL2rxg4xzF69+yLPYvPSUbpd+PA343X1bjo8eAVXKuZoRwQohRTJZm6O9flHJ
GRWdXiQp14NxBve36FAUS78okFSeaIMGFnLXdVhh86Hizk8jjIi0HNtyBE7tEAmw
P2gw/HSfvFPr8SyVDm7H
=l749
-----END PGP SIGNATURE-----

--6zdv2QT/q3FMhpsV--