incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andre Fischer ...@a-w-f.de>
Subject Re: [CODE] configure.in: yes/no messages swapped in --enable-copyleft
Date Mon, 21 Nov 2011 08:57:50 GMT
Hi Andrea,

good point but please keep in mind that this is a temporary workaround. 
  Much work is currently being done to remove the category x license 
code.  When that is done we need a different switch to make the category 
b license code (eg MPL) optional.  Therefore the --enable-copyleft 
switch will not live for very long.

Regards,
Andre

On 21.11.2011 00:27, Andrea Pescetti wrote:
> It seems that the "yes" and "no" messages corresponding to the
> "--enable-copyleft" option are swapped in configure.in; this has no
> impact on the build, but it gives the user a wrong feedback about the
> options he specified.
>
> The fix would just consist in swapping the "yes" and "no" messages; for
> those who prefer to see it in the form of a (trivial) patch, here it is.
> ---
> Index: configure.in
> ===================================================================
> --- configure.in (revision 1204230)
> +++ configure.in (local copy)
> @@ -1233,37 +1233,37 @@
> AC_MSG_CHECKING([whether to enable copyleft components])
> if test "$enable_copyleft" != "yes"; then
>
> enable_mozilla="no"
> enable_nss_module="no"
> enable_gstreamer="no"
> with_myspell_dicts="no"
>
> DISABLE_HUNSPELL="TRUE"
> DISABLE_HYPHEN="TRUE"
> DISABLE_SAXON="TRUE"
>
> BUILD_EPM="NO"
>
> - AC_MSG_RESULT([yes])
> + AC_MSG_RESULT([no])
>
> else
>
> DISABLE_HUNSPELL=
> DISABLE_HYPHEN=
> DISABLE_SAXON=
>
> - AC_MSG_RESULT([no])
> + AC_MSG_RESULT([yes])
>
> fi
> AC_SUBST(DISABLE_HUNSPELL)
> AC_SUBST(DISABLE_HYPHEN)
> AC_SUBST(DISABLE_SAXON)
> AC_SUBST(BUILD_EPM)
>
>
> AC_MSG_CHECKING([whether to enable native CUPS support])
> if test "$test_cups" = "yes" -a \( "$enable_cups" = "yes" -o
> "$enable_cups" = "TRUE" \) ; then
> ENABLE_CUPS="TRUE"
> AC_MSG_RESULT([yes])
> else
> ENABLE_CUPS=""
> ---
> Regards,
> Andrea.

Mime
View raw message