incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ariel Constenla-Haile <arie...@apache.org>
Subject Re: [Patch]submit a patch to fix the issue - 115580.
Date Thu, 17 Nov 2011 18:33:10 GMT
Hello Pedro, *

On Thu, Nov 17, 2011 at 07:26:08AM -0800, Pedro Giffuni wrote:
> Committed as revision 1203218.
> 
> Thank you very much for your contribution!
> 
> Pedro.
> 

+       //#115580# fixed by JingDongChen from China at 2011/11/16 start
+       //#115580# fixed by JingDongChen from China at 2011/11/16 end

+       //#115580# fixed by JingDongChen from China at 2011/11/16 start
+       //#115580# fixed by JingDongChen from China at 2011/11/16 end

+       //#115580# fixed by JingDongChen from China at 2011/11/16 start
+       //#115580# fixed by JingDongChen from China at 2011/11/16 end

+               //#115580# fixed by JingDongChen from China at 2011/11/16 start
+               //#115580# fixed by JingDongChen from China at 2011/11/16 end

+               //#115580# fixed by JingDongChen from China at 2011/11/16 start
+               //#115580# fixed by JingDongChen from China at 2011/11/16 end

+       //#115580# fixed by JingDongChen from China at 2011/11/16 start
+       //#115580# fixed by JingDongChen from China at 2011/11/16 end

....

IMHO those kind of comments shouldn't be commited, the commit log speaks by 
itself, it is redundant to add the issue number, the date and the author name 
to every block of code. Just imagine everyone starts to do the same, the source 
would be a mess.

Regards
-- 
Ariel Constenla-Haile
La Plata, Argentina

Mime
View raw message