incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ariel Constenla-Haile <ariel.constenla.ha...@gmail.com>
Subject Re: [code] [issue 118517] Twain header update for testing
Date Tue, 01 Nov 2011 06:12:48 GMT
Hi Pedro,

On Fri, Oct 28, 2011 at 03:12:42PM -0700, Pedro Giffuni wrote:
> Hi again;
> 
> I waited for a while but I didn't get any report on how
> well (or bad) the new twain header works while building
> on Windows. I am pretty sure the authors take care of
> GCC and most commercial compilers so the only special
> case is mingw32.
> 
> Ming32 is something that was indeed hacked into our old
> header so I adapted the code to suit our previous behavior
> and now that I have something robust I have committed it.
> I did everything I could to ensure this works but I am not
> perfect, and there has been little feedback, so please
> don't panic and let me know if something related with
> scanners changes.

I didn't test scanning, but building breaks:

ifdef defined(TWH_CMP_MING32)
     #pragma pack (push, 2)
#elif TWH_CMP_MSC

see attached patch.

Regards
-- 
Ariel Constenla-Haile
La Plata, Argentina

Mime
View raw message