incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pedro Giffuni <...@apache.org>
Subject Re: System broken at mythes
Date Tue, 22 Nov 2011 23:09:57 GMT
BTW,

Instead of setting

ENABLE_EXAMPLE="no"

and then a conditional, why not just avoid the extra
conditionals and change line 88 to

PROGRAMS=

:)

cheers,

Pedro.

--- On Tue, 11/22/11, Ariel Constenla-Haile <arielch@apache.org> wrote:

> From: Ariel Constenla-Haile <arielch@apache.org>
> Subject: Re: System broken at mythes
> To: ooo-dev@incubator.apache.org
> Date: Tuesday, November 22, 2011, 5:48 PM
> 
> Hi Pedro,
> 
> On Tue, Nov 22, 2011 at 02:00:40PM -0800, Pedro Giffuni
> wrote:
> > 
> > 
> > --- On Tue, 11/22/11, Ariel Constenla-Haile <arielch@apache.org>
> wrote:
> > 
> > > From: Ariel Constenla-Haile <arielch@apache.org>
> > > Subject: Re: System broken at mythes
> > > To: ooo-dev@incubator.apache.org
> > > Date: Tuesday, November 22, 2011, 4:41 PM
> > > Hi Pedro,
> > > 
> > > On Tue, Nov 22, 2011 at 01:16:47PM -0800, Pedro
> Giffuni
> > > wrote:
> > > > Hello;
> > > > 
> > > > I am getting this after r1204995 :
> > > > 
> > > > ...
> > > > =============
> > > > Building module mythes
> > > > =============
> > > > 
> > > > ...
> > > > configure: creating ./config.status
> > > > config.status: creating Makefile
> > > > config.status: creating mythes.pc
> > > > config.status: creating config.h
> > > > config.status: executing depfiles commands
> > > > config.status: executing libtool commands
> > > > mkdir:
> ./unxfbsdx.pro/misc/build/mythes-1.2.0/: File
> > > exists
> > > > "Makefile", line 88: Need an operator
> > > > "Makefile", line 90: Need an operator
> > > > "Makefile", line 92: Need an operator
> > > 
> > > this looks like the lines that disable building
> the
> > > example.
> > > In my generated Makefile they look like
> > > 
> > > ifeq "$(ENABLE_EXAMPLE)" "no"
> > > PROGRAMS=
> > > else
> > > PROGRAMS = $(noinst_PROGRAMS)
> > > endif
> > > 
> > It looks exactly like yours:
> > ...
> > libmythes_1_2_la_OBJECTS =
> $(am_libmythes_1_2_la_OBJECTS)
> > ifeq "$(ENABLE_EXAMPLE)" "no"
> > PROGRAMS=
> > else
> > PROGRAMS = $(noinst_PROGRAMS)
> > endif
> 
> now that I look at it, is seems tabs were removed in the
> patch, anyway,
> in cygwin and Fedora it compiled, and the syntax is right
> http://www.gnu.org/s/hello/manual/make/Conditional-Syntax.html
> 
> Please try running make directly inside
> /unxfbsdx.pro/misc/build/mythes-1.2.0
> after changing the following:
> 
> * add tabs:
> 
> ifeq "$(ENABLE_EXAMPLE)" "no"
>     PROGRAMS=
> else
>     PROGRAMS = $(noinst_PROGRAMS)
> endif
> 
> (sure you get the idea though vim is replacing now the tabs
> by spaces).
> Googling for "Need an operator" most entries are FreeBSD
> related...
> looks like I'll install FreeBSD on a VM. In the mean time
> try playing
> with these lines in the Makefile and running make/gmake in
> that folder
> to see if something works.
> 
> 
> > am_example_OBJECTS = example.$(OBJEXT)
> > ...
> > 
> > FYI:
> > 
> > > gmake --version
> > GNU Make 3.82
> 
> the same version here
> 
> > Built for amd64-portbld-freebsd9.0
> > > gpatch --version
> > patch 2.6.1
> 
> same here.
> (it does not mean much, sure both version are not
> upstream)
> 
> 
> Regards
> -- 
> Ariel Constenla-Haile
> La Plata, Argentina
> 

Mime
View raw message