incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pedro Giffuni <...@apache.org>
Subject Re: [Patch]submit a patch to fix the issue - 115580.
Date Thu, 17 Nov 2011 16:40:27 GMT


--- On Thu, 11/17/11, J├╝rgen Schmidt <jogischmidt@googlemail.com> wrote:

> On 11/17/11 4:26 PM, Pedro Giffuni
> wrote:
> > Committed as revision 1203218.
> > 
> > Thank you very much for your contribution!
> > 
> 
> i very much appreciate that we accept and integrate
> everything at the moment. But should we maybe a little bit
> more careful? And should we focus more on our main common
> goal to provide a stable version asap?
> 
> I thought we would have agreed to only make the code base
> Apache conform and work on replacements for license critical
> things. We are now in a phase where we integrate many
> patches from Issuezilla that are not yet integrated for
> specific reasons (maybe not reviewed, not complete, too bad
> etc.). We integrate things without real testing the changes.
> I am not sure if we should do that at the moment.
> 
> What do others think about it?
> 

OK, I agree that I've been very light on my review of what
should be committed: in this case I took into account that
the submitter knows well the code and the issue is clearly
evidenced in the bugzilla report.

I think we should be much more proactive here at Apache,
and the situation where bugs are extremely old is not
really desirable (and that's, I think, the idea behind
"lazy consensus").

I will slow down though, I understand perfectly that I
cannot go around destabilizing things while you guys are
doing important cleanups.

Pedro.

Mime
View raw message