Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ooo-dev@incubator.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <1318383781.84464.YahooMailClassic@web113514.mail.gq1.yahoo.com>
Date: Tue, 11 Oct 2011 18:43:01 -0700 (PDT)
From: Pedro Giffuni <pfg@apache.org>
Reply-To: pfg@apache.org
Subject: Re: [PATCH] Fix for #118485#, #108221#, #67705#
To: ooo-dev@incubator.apache.org
In-Reply-To: <j70vir$gbt$1@dough.gmane.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

Hi;=0A=0AI committed it as revision 1182166, and noted it in the=0Abug repo=
rt, but I admit the patch was too big to do a=0Areview on it.=0A=0AIt was e=
vidently a lot of work that I would hate to see=0Aignored and, if I underst=
and well, this was like *really*=0Abroken (3 issues) but in the future I wi=
ll try to avoid=0Acommitting these big patches without someone else=0Arevie=
wing it first.=0A=0APedro.=0A=0A--- On Tue, 10/11/11, Armin Le Grand <Armin=
.Le.Grand@me.com> wrote:=0A...=0A> =A0=A0=A0 Hi *,=0A> =0A> I took some day=
s to fix that long missing OLE-Attribute=0A> feature/bug. It is on one hand=
 a missing feature (no reason=0A> to not apply attributes and transformatio=
ns to OLE which=0A> contains the same as graphical object, a MetaFile) and =
on=0A> the other a compatibility issue with a big competitor which=0A> is a=
ble to add attributes to OLEs for a long time.=0A> =0A> This fix was alread=
y prepared in #67705# but could not be=0A> activated due to a missing part =
of #108221#. Thanks to ORW=0A> (aka Oliver-Rainer) which helped to solve th=
at.=0A> =0A> The patch adds LineStyle, FillStyle, Text, Shadow, Shear=0A> a=
nd Rotate to OLE objects in Draw/Impress and Calc. It adds=0A> Shear to gra=
phic objects. It also fixes some long=0A> existing=A0 not detected bugs to =
make all this work. It=0A> leaves OLEs and graphical objects for Writer (SW=
) untouched=0A> due to the fact that SW uses it's own implementations for=
=0A> those (one more argument for the long missing consolidation=0A> in SW =
to use DrawingLayer objects for this).=0A> =0A> Details are documented in h=
ttps://issues.apache.org/ooo/show_bug.cgi?id=3D118485,=0A> but here is a li=
st:=0A> =0A> - Added LineStyle, FillStyle, Text, Shadow, Shear, Rotate=0A> =
to OLE=0A> - Added Shear to GraphicObjects=0A> - Adapted context menus in D=
raw/Impress, Calc=0A> - Adapted UNO API to allow these attribute families f=
or=0A> those object types=0A> - Adapted interactors to show a correct previ=
ew for=0A> interactions=0A> - Adapted ConvertTo to take set attributes into=
 account=0A> (was completely missing for GraphicObjects, a bug on it's=0A> =
own).=0A> - Adapted Text edit activation (press any key to start=0A> typing=
), activation on Return stays untouched=0A> - Adapted OLE activation to be =
centered to the now=0A> eventually rotated/sheared object bounds=0A> - Adap=
ted MetaFile-ToSdrObject converter, transformations=0A> are now applied to =
the created SdrObjects. Deactivated one=0A> erroneous Item in text attribut=
e creation which leads to bad=0A> errors in text generation, wrote f'up #11=
8498# for it (HDU)=0A> - Adapted Import/Export to take care of added text=
=0A> - Added correction for earlier written OOo ODF files at=0A> load time=
=0A> - Activated the prepared attribute visualization in the OLE=0A> Primit=
ive=0A> - Corrected attribute generation for newly created OLEs=0A> =0A> I =
checked all changes again and added the patch to=0A> #118485#. Now I'm look=
ing for someone volunteering to add=0A> the patch, build AOOo and play arou=
nd with OLEs a little=0A> bit, reading the patch will also help in this cas=
e, it's not=0A> too big to do so.=0A> =0A> The change looks big, but it tou=
ches no too critical parts.=0A> It is also necessary to bring it in AOOo3.4=
, this change=0A> relies on a version change (here: 3.3 to 3.4) to be able =
to=0A> correct files written by OOo up to 3.3 (and only those).=0A> =0A> So=
me background: The root problem here was that older=0A> versions straight i=
gnored attributes set at OLE objects by=0A> just not painting them. This me=
ans that in files generated=0A> the attributes are written and in plain ODF=
 OLEs are filled=0A> default (blue8) and have line on default (black hairli=
ne).=0A> =0A> Questions/Comments are welcome,=0A> =A0=A0=A0 Armin=0A> --=0A=
> ALG=0A> =0A>