Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ooo-dev@incubator.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <1317999389.93521.YahooMailClassic@web113509.mail.gq1.yahoo.com>
Date: Fri, 7 Oct 2011 07:56:29 -0700 (PDT)
From: Pedro Giffuni <pfg@apache.org>
Reply-To: pfg@apache.org
Subject: Re: [CODE] gtk system tray icon and libegg
To: ooo-dev@incubator.apache.org
In-Reply-To: <20111006081156.GA2836@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

Hello ariel;=0A=0A--- On Thu, 10/6/11, Ariel Constenla-Haile <ariel.consten=
la.haile@gmail.com> wrote:=0A...=0A> Hi there,=0A> =0A> the GTK system tray=
 is broken:=0A> =0A> 1) ENABLE_QUICKSTART_APPLET is not defined, so=0A> Shu=
tdownIcon::IsQuickstarterInstalled()=0A> =A0=A0=A0returns false, instead of=
 trying to load=0A> libqstart_gtk.so=0A> =A0=A0=A0http://svn.apache.org/vie=
wvc/incubator/ooo/trunk/main/sfx2/source/appl/shutdownicon.cxx?view=3Dmarku=
p#l769=0A> =0A> 2) ENABLE_SYSTRAY_GTK is not defined, so the plugin library=
=0A> name is not=0A> =A0=A0=A0defined=0A> =A0=A0=A0http://svn.apache.org/vi=
ewvc/incubator/ooo/trunk/main/sfx2/source/appl/shutdownicon.cxx?view=3Dmark=
up#l96=0A> =A0=A0=A0http://svn.apache.org/viewvc/incubator/ooo/trunk/main/s=
fx2/source/appl/shutdownicon.cxx?view=3Dmarkup#l159=0A> =0A> 3) the library=
 name should be modified, due to changes in=0A> the DLLPOSTFIX;=0A> =A0=A0=
=A0and should not be a string, because it is=0A> stringified (or PLUGIN_NAM=
E=0A> =A0=A0=A0could be defined in the Makefile)=0A> =0A> 4) the GTK system=
 tray depends on libegg, a LGPL v2+=0A> library. Quite=0A> =A0=A0=A0strange=
 the library is build but not=0A> installed. This causes that the=0A> =A0=
=A0=A0libqstart_gtk.so cannot be loaded.=0A> =A0=A0=A0libegg is copy-left, =
so it should be=0A> replaced by GtkStatusIcon=0A> =A0=A0=A0(requires at mos=
t gtk 2.16)=0A> =A0=A0=A0http://developer.gnome.org/gtk/2.24/GtkStatusIcon.=
html=0A> =A0=A0=A0This looks like an easy task.=0A> =0A=0AFWIW, libegg is i=
ndeed something we have to get rid of, not=0Aonly due to the license issue =
but because it looks like it's=0Adeprecated: the code was made part of gtk =
and has been=0Achanging a lot since then. I looks like the code we have is=
=0Anot available independently so using the functionality in=0AGTK is the w=
ay to go.=0A=0A> 5) trunk/main/sfx2/source/appl/shutdowniconunx.cxx has no=
=0A> license=A0header. Is this file in the software=0A> grant? =0A> =A0=A0=
=A0Looking at the hg log, it comes from:=0A> =0A> changeset:=A0=A0=A0174966=
:ddd13100457e=0A> user:=A0 =A0 =A0 =A0 kz=0A> date:=A0 =A0 =A0 =A0 Fri Oct =
06 10:39:32 2006=0A> +0000=0A> files:=A0 =A0=0A> =A0=A0=A0sfx2/source/appl/=
shutdowniconunx.cxx=0A> description:=0A> INTEGRATION: CWS gtkquickstart (1.=
1.2); FILE ADDED=0A> 2006/08/01 10:59:27 mmeeks 1.1.2.2: Issue number: i#57=
872#=0A> Submitted by: mmeeks=0A> Warning fixes.=0A> 2006/08/01 10:57:04 mm=
eeks 1.1.2.1: #i57872#=0A> gtk systray quickstarter=0A> =0A> https://issues=
.apache.org/ooo/show_bug.cgi?id=3D57872=0A> first comment says something ab=
out JCAs, but I don't get=0A> it.=0A>=0A=0AMy guess is that mmeeks signed a=
 JCA for his code and=0Awas even willing to get a JCA for libegg too. His c=
ode=0Ashould be covered by the grant but I have no idea what=0Athe lawyers =
will do since there is no copyright header=0A(probably just be conservative=
 and say no).=0AThere is an initial grant already but I forgot where it=0Ai=
s.=0A=0A> Attached patch solves (1) and (2) but is useless until=0A> knowin=
g the status of (5) and then fixing (4).=0A>=0A=0AI think a patch for (4) w=
ould be the way to go. I am in=0Ano position to review your patches for (1)=
 and (2),=0Ahopefully someone else can.=0A=0AThanks for the research!=0A=0A=
Pedro.