incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Weir <robw...@apache.org>
Subject Re: [PATCH] Fix for #118485#, #108221#, #67705#
Date Wed, 12 Oct 2011 16:20:20 GMT
On Wed, Oct 12, 2011 at 11:47 AM, Pedro Giffuni <pfg@apache.org> wrote:
> Hi;
>
> --- On Wed, 10/12/11, Armin Le Grand <Armin.Le.Grand@me.com> wrote:
>
>>     Hi Pedro,
>>
>> On 12.10.2011 03:43, Pedro Giffuni wrote:
>> > Hi;
>> >
>> > I committed it as revision 1182166, and noted it in
>> > the bug report, but I admit the patch was too big to do
>> > a review on it.
>>
>> Thanks for comitting. I think - as i wrote - for someone
>> knowing the  core it would have been possible to read the
>> diffs. This is not too big from my POV, I have bigger
>> changes in the pipeline.
>>
>
> Oh yes, it was not that big, but it touched a lot of files
> which made it difficult to get the context. In any case
> big patches are sometimes necessary and I was confident
> this wouldn't go bad: it was my way of saying "this guy
> should be a committer so he can fix the stuff he breaks"
> :),
>

+1

> Another thing is that we should be focusing on removing
> copyleft components and perhaps some cleanups before
> doing enhancements. I specifically want to avoid the
> situation in LO where the code and the configuration
> options keep growing and growing without control to
> the point where patches occasionally make gcc run
> out of memory.
>
> I am very likely to commit stuff in these lines if I
> get good patches:
>
> - Removal of libegg.
> - Use of OpenSSL instead of nss for AES encryption.
> - replacement of glibc (already discussed in the list)
> - Updates to the scanner (sane and twain) headers.
> - Updating ICC.
> - Bring back Xalan.
> - Replace Rhino with V8 !
>
> And the list will probably grow as ideas keep coming in ;-)
>
> Pedro.
>

Mime
View raw message